Re: [PATCH] [MTD] physmap: remove physmap_flash_shutdown() method.

[Vladimir Zapolskiy <vzapolskiy@gmail.com>]

Hello David,

please could you be so kind to share your objections about the proposed
change?

Thank you in advance.

Vladimir Zapolskiy <vzapolskiy@gmail.com> writes:

> physmap driver operates with cfi, jedec, qinfo and map_rom compliant
> chips. None of interface drivers for all these chips uses actual
> suspend and resume chip operations, but correspondent two methods only
> change flash chip state in drivers' internal state machines, and for
> Intel chips save/restore block locks is done.
>
> To operate with boards with Intel flash chips where RP# pin is not
> asserted on reset there is an already implemented mechanism of reboot
> notifiers, and on reboot the flash moves into defined "read array"
> state.
>
> If CONFIG_PM kernel option is enabled, then physmap_flash_shutdown()
> method is called after reboot notifier work, and save/restore block
> locks operations disturb the chip from default "read array" state,
> thus if the flash is a bootable one, board cann't be booted from it
> after reset.
>

With best wishes,
Vladimir