From: "Bjørn Mork" <bjorn@mork.no>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Jussi Kivilinna <jussi.kivilinna@iki.fi>,
Joern Engel <joern@logfs.org>,
linux-usb@vger.kernel.org, linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] alauda: do not use stack for URB transfer_buffers
Date: Wed, 21 Aug 2013 09:59:27 +0200 [thread overview]
Message-ID: <87li3v79uo.fsf@nemi.mork.no> (raw)
In-Reply-To: <20130821073028.GB31788@brian-ubuntu> (Brian Norris's message of "Wed, 21 Aug 2013 00:30:28 -0700")
Brian Norris <computersforpeace@gmail.com> writes:
> On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote:
>> Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to
>> be DMA-able, which stack is not.
>>
>> Patch is only compile tested.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi>
>> ---
>> drivers/mtd/nand/alauda.c | 74 ++++++++++++++++++++++++++++++++++-----------
>> 1 file changed, 56 insertions(+), 18 deletions(-)
>
> Just FYI, this driver is being removed, so I'm obviously not taking this
> patch :)
I think you should apply it anyway. The driver is still in v3.11 AFAICS,
and the patch should also go to the maintained stable kernels. You
cannot remove the driver from them, and I don't see a later driver
removal as a valid reason not to fix a known bug with a patch.
Bjørn
next prev parent reply other threads:[~2013-08-21 7:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 12:03 [PATCH] alauda: do not use stack for URB transfer_buffers Jussi Kivilinna
2013-08-06 16:49 ` Jörn Engel
2013-08-07 5:50 ` Jussi Kivilinna
2013-08-07 15:16 ` Jörn Engel
2013-08-21 7:30 ` Brian Norris
2013-08-21 7:59 ` Bjørn Mork [this message]
2013-08-21 8:41 ` Brian Norris
2013-08-21 9:59 ` Jussi Kivilinna
2013-08-21 20:00 ` Brian Norris
2013-08-21 19:06 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li3v79uo.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=joern@logfs.org \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox