From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
linux-mtd@lists.infradead.org,
Jakub Czapiga <czapiga@google.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 2/2] mtd: spi-nor: Rename spi_nor_spimem_check_op()
Date: Tue, 17 Mar 2026 10:33:43 +0100 [thread overview]
Message-ID: <87ms06er60.fsf@bootlin.com> (raw)
In-Reply-To: <230c1e00-25c2-44f7-afa5-a8ccbcf145db@linaro.org> (Tudor Ambarus's message of "Tue, 10 Mar 2026 11:54:03 +0200")
>> -static int spi_nor_spimem_check_op(struct spi_nor *nor,
>> - struct spi_mem_op *op)
>> +static int spi_nor_spimem_check_page_op(struct spi_nor *nor,
>> + struct spi_mem_op *op)
>
> page is a bit misleading as it can indicate it's used just for page
> programs. We need to focus on operations that need address bytes,
> reads, pp, page scrub, erase, write/read any register, etc.
This helper is only used for reads and page programs. The point is
to not use it when reading/writing registers.
What about spi_nor_spimem_check_io_op() ? or _iorw_op() ?
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-03-17 9:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 12:14 [PATCH 1/2] mtd: spi-nor: Fix RDCR controller capability core check Miquel Raynal
2026-01-08 12:14 ` [PATCH 2/2] mtd: spi-nor: Rename spi_nor_spimem_check_op() Miquel Raynal
2026-03-10 9:54 ` Tudor Ambarus
2026-03-17 9:33 ` Miquel Raynal [this message]
2026-03-17 11:39 ` Tudor Ambarus
2026-03-17 13:18 ` Miquel Raynal
2026-03-09 14:55 ` [PATCH 1/2] mtd: spi-nor: Fix RDCR controller capability core check Miquel Raynal
2026-03-10 9:24 ` Tudor Ambarus
2026-03-10 9:38 ` Tudor Ambarus
2026-03-17 9:21 ` Miquel Raynal
2026-03-17 9:20 ` Miquel Raynal
2026-03-17 9:25 ` Tudor Ambarus
2026-03-11 7:02 ` Takahiro.Kuwano
2026-03-13 11:10 ` Pratyush Yadav
2026-03-13 14:34 ` Miquel Raynal
2026-03-13 16:42 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ms06er60.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=czapiga@google.com \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox