From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Nathan Chancellor <nathan@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
David Woodhouse <dwmw2@infradead.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] mtd: dc21285: fix bytewise memcpy()
Date: Thu, 07 Aug 2025 09:54:38 +0200 [thread overview]
Message-ID: <87o6srd0sh.fsf@bootlin.com> (raw)
In-Reply-To: <20250807072044.4146480-1-arnd@kernel.org> (Arnd Bergmann's message of "Thu, 7 Aug 2025 09:20:34 +0200")
Hello Arnd,
On 07/08/2025 at 09:20:34 +02, Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The commit that split up the 8/16/32-bit operations in 2004 seems to have
> broken the 8-bit case, as clang-21 now points out:
>
> drivers/mtd/maps/dc21285.c:129:97: error: parameter 'len' set but not used [-Werror,-Wunused-but-set-parameter]
> 129 | static void dc21285_copy_to_8(struct map_info *map, unsigned long to, const void *from, ssize_t len)
>
> Put back the loop that was in linux-2.6.8 and earlier for this case.
>
> Fixes: 67d4878e4e61 ("NOR flash drivers update")
> Cc: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the patch, I'll take it, but that probably means few to no
people still use it, if broken for more than 20 years...
Cheers,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-08-07 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 7:20 [PATCH] mtd: dc21285: fix bytewise memcpy() Arnd Bergmann
2025-08-07 7:54 ` Miquel Raynal [this message]
2025-08-07 11:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6srd0sh.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dwmw2@infradead.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox