From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Brian Norris <computersforpeace@gmail.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Antoine Tenart <antoine.tenart@free-electrons.com>
Subject: Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config
Date: Mon, 17 Aug 2015 00:22:28 +0200 [thread overview]
Message-ID: <87oai6an6j.fsf@belgarion.home> (raw)
In-Reply-To: <20150816213655.GA4585@laptop.cereza> (Ezequiel Garcia's message of "Sun, 16 Aug 2015 18:36:55 -0300")
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
> On 11 Aug 09:57 PM, Robert Jarzmik wrote:
>> The cases of READID detection are broken on pxa3xx. The reason is that
>> in the early stages of nand probing, ie. at pxa3xx_nand_scan(), we
>> always have :
>> - info->use_dma = 0 (regardless of dma support yet)
>> - info->chunk_size = 0 (not yet detected)
>>
>> The READID issued by pxa3xx_nand_scan() will therefore end up in
>> handle_data_pio(), and do_bytes will be 0, leading to not reading the
>> nand id, and blocking detection.
>>
>> This doesn't happen if "keep_config" is used, which is probably the most
>> tested case.
>>
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>> Fixes: 70ed85232a93 ("mtd: nand: pxa3xx: Introduce multiple page I/O
>> support")
>
> To be fair, Antoine submitted this a while ago:
>
> http://lists.infradead.org/pipermail/linux-mtd/2015-April/058739.html
>
> Not sure which one takes precedence in such a case (and yours
> has a proper Fixes tag).
His has precedence. How is it that a fix patch is not yet merge since April ?
Is it because it's part of a still in review serie ?
Cheers.
--
Robert
next prev parent reply other threads:[~2015-08-16 22:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 19:57 [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug Robert Jarzmik
2015-08-11 19:57 ` [PATCH 2/3] mtd: nand: pxa3xx_nand: fix early spurious interrupt Robert Jarzmik
2015-08-11 19:57 ` [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config Robert Jarzmik
2015-08-16 21:36 ` Ezequiel Garcia
2015-08-16 22:22 ` Robert Jarzmik [this message]
2015-08-17 17:31 ` Ezequiel Garcia
2015-08-17 19:03 ` Robert Jarzmik
2015-08-18 8:59 ` Antoine Tenart
2015-08-18 4:24 ` [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug Ezequiel Garcia
2015-08-18 18:26 ` Robert Jarzmik
2015-08-23 19:09 ` Robert Jarzmik
2015-08-24 13:46 ` Ezequiel Garcia
2015-12-19 0:48 ` Brian Norris
2015-12-19 12:19 ` Robert Jarzmik
2016-01-07 0:04 ` Brian Norris
2016-01-07 0:06 ` Brian Norris
2016-01-10 20:34 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oai6an6j.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=antoine.tenart@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).