Re: [PATCH v2] mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd'

[Robert Jarzmik <robert.jarzmik@free.fr>]

Brian Norris <computersforpeace@gmail.com> writes:

> With this removal, we don't need to 'get' the second DMA resource
> either, as it's also unused.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
> On Sat, Mar 05, 2016 at 09:34:14AM +0100, Robert Jarzmik wrote:
>> Brian Norris <computersforpeace@gmail.com> writes:
>> > @@ -1812,7 +1811,6 @@ static int alloc_nand_resource(struct platform_device *pdev)
>> >  			ret = -ENXIO;
>> >  			goto fail_disable_clk;
>> >  		}
>> > -		info->drcmr_cmd = r->start;
>> >  	}
>> If you kill this field, why not kill also this block just above ?
>> 		r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
>> 		if (r == NULL) {
>> 			dev_err(&pdev->dev,
>> 				"no resource defined for cmd DMA\n");
>> 			ret = -ENXIO;
>> 			goto fail_disable_clk;
>> 		}
>
> Indeed, why not.
>
>  drivers/mtd/nand/pxa3xx_nand.c | 10 ----------
>  1 file changed, 10 deletions(-)
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert