From: Robert Jarzmik <robert.jarzmik@free.fr>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3] mtd/docg3: fixes and cleanups
Date: Fri, 16 Dec 2011 23:25:23 +0100 [thread overview]
Message-ID: <87pqfow3vw.fsf@free.fr> (raw)
In-Reply-To: <874nx5zbuj.fsf@free.fr> (Robert Jarzmik's message of "Mon, 12 Dec 2011 23:03:48 +0100")
> Artem Bityutskiy <dedekind1@gmail.com> writes:
>
>> On Fri, 2011-12-09 at 17:13 +0100, Robert Jarzmik wrote:
>> May be it is better to just embrace this function with "#ifdef 0" and add a
>> comment that we can do this but do not have a good use for this?
> Ah yes, I didn't think about that possibility. It's looks better, I'll submit
> another patch with a comment and the #if 0.
How about the following patch ?
Cheers.
--
Robert
>From 75cb409a2a98070584cbf7a9f8ccfe621cf29018 Mon Sep 17 00:00:00 2001
From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: Fri, 9 Dec 2011 17:02:49 +0100
Subject: [PATCH] mtd: docg3: remove unused function
As the MTD api has no use for the number of erase cycles
each block has endured, remove the function which calculated
that value.
If one day MTD api finds it usefull for wear levelling
algorithms to have this information, the function should be
put back in place.
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
drivers/mtd/devices/docg3.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
index 2a32072..22d5099 100644
--- a/drivers/mtd/devices/docg3.c
+++ b/drivers/mtd/devices/docg3.c
@@ -1037,6 +1037,7 @@ static int doc_block_isbad(struct mtd_info *mtd, loff_t from)
return !is_good;
}
+#if 0
/**
* doc_get_erase_count - Get block erase count
* @docg3: the device
@@ -1078,6 +1079,7 @@ static int doc_get_erase_count(struct docg3 *docg3, loff_t from)
return max(plane1_erase_count, plane2_erase_count);
}
+#endif
/**
* doc_get_op_status - get erase/write operation status
--
1.7.5.4
next prev parent reply other threads:[~2011-12-16 22:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 22:09 [PATCH v2] mtd/docg3: fixes and cleanups Robert Jarzmik
2011-12-01 8:05 ` Artem Bityutskiy
2011-12-02 18:57 ` Robert Jarzmik
2011-12-02 19:00 ` [PATCH v3] " Robert Jarzmik
2011-12-05 6:31 ` Artem Bityutskiy
2011-12-07 20:45 ` Robert Jarzmik
2011-12-09 16:13 ` Robert Jarzmik
2011-12-12 21:13 ` Artem Bityutskiy
2011-12-12 22:03 ` Robert Jarzmik
2011-12-13 4:16 ` Mike Dunn
2011-12-16 22:25 ` Robert Jarzmik [this message]
2011-12-17 15:08 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqfow3vw.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).