From: Peter Korsgaard <jacmet@sunsite.dk>
To: dedekind1@gmail.com
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: Latest mkfs.jffs2 is broken.
Date: Fri, 15 Oct 2010 10:35:34 +0200 [thread overview]
Message-ID: <87pqvbetux.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1287123245.18576.2.camel@localhost> (Artem Bityutskiy's message of "Fri, 15 Oct 2010 09:14:05 +0300")
>>>>> "Artem" == Artem Bityutskiy <dedekind1@gmail.com> writes:
Hi,
Artem> On Thu, 2010-10-14 at 16:54 -0500, H Hartley Sweeten wrote:
Artem> Could you please bisect the mtd-utils.git tree and find the offending
Artem> commit.
With big endian atleast, jffs2dump complains about invalid hdr_crc on
1.4.0, but it's working on HEAD. A bisect shows that the commit fixing
it was Mike's:
commit b864c387e8f16273aad1453d6457d847e29c3d25
Author: Mike Frysinger <vapier@gentoo.org>
Date: Wed Sep 22 22:32:56 2010 -0400
mtd-utils: clean up zlib.h usage a bit
Hide zlib's crc32 in compr_zlib.c and mkfs.ubifs/compr.c.
jffs2reader.c and mkfs.jffs2.c don't actually use zlib, so punt the
include from the file.
mkfs.jffs2.c is implicitly using crc32 from zlib.h instead of the
local mtd_crc32, so fix the local usage. otherwise we get warnings
about undefined crc32 because the file was redirecting the prototype.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Hartley, that commit applies OK to 1.4.0, could you give it a try?
Artem: Time for a v1.4.1 release?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2010-10-15 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 21:54 Latest mkfs.jffs2 is broken H Hartley Sweeten
2010-10-15 6:14 ` Artem Bityutskiy
2010-10-15 8:35 ` Peter Korsgaard [this message]
2010-10-15 8:43 ` Artem Bityutskiy
2010-10-15 8:52 ` Peter Korsgaard
2010-10-16 15:49 ` Artem Bityutskiy
2010-10-16 20:19 ` Peter Korsgaard
2010-10-18 20:51 ` Peter Korsgaard
2010-10-19 4:49 ` Artem Bityutskiy
2010-10-19 8:38 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqvbetux.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=dedekind1@gmail.com \
--cc=hartleys@visionengravers.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).