From: Esben Haabendal <esben@geanix.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: vigneshr@ti.com, richard@nod.at, s.hauer@pengutronix.de,
sean@geanix.com, boris.brezillon@collabora.com,
linux-mtd@lists.infradead.org, martin@geanix.com,
Han Xu <han.xu@nxp.com>
Subject: Re: [PATCH] mtd: rawnand: gpmi: fix the suspend/resume issue
Date: Thu, 09 Jan 2020 21:06:07 +0100 [thread overview]
Message-ID: <87v9pkmm34.fsf@geanix.com> (raw)
In-Reply-To: <20200109200127.0ace18cb@xps13> (Miquel Raynal's message of "Thu, 9 Jan 2020 20:01:27 +0100")
Miquel Raynal <miquel.raynal@bootlin.com> writes:
> Hi Esben, Han,
>
> Han Xu <han.xu@nxp.com> wrote on Fri, 10 Jan 2020 01:05:56 +0800:
>
>> fix several issues when system suspend/resume,
>>
>> - leverage the runtime pm for system suspend/resume
>> - enable the clock before register access
>> - re-apply timing settings
>> - set the proper pinctrl state
>
> Esben are you fine with this patch?
It sounds like something that should probably be 4 separate patches.
> Or maybe Han you could take over Esben's patch and extend it?
I don't see why my two patches, which covers point 1 and 3 in the list
of issues covered by Han's patch, should not be merged.
Han, would you mind re-spin your patch to two separate patches covering
the remaining issues
- enable the clock before register access
- set the proper pinctrl state
/Esben
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-09 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 17:05 [PATCH] mtd: rawnand: gpmi: fix the suspend/resume issue Han Xu
2020-01-09 19:01 ` Miquel Raynal
2020-01-09 20:06 ` Esben Haabendal [this message]
2020-01-09 20:09 ` Han Xu
2020-01-13 17:30 ` Miquel Raynal
2020-01-09 20:45 ` Esben Haabendal
2020-01-14 21:53 ` Han Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9pkmm34.fsf@geanix.com \
--to=esben@geanix.com \
--cc=boris.brezillon@collabora.com \
--cc=han.xu@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=martin@geanix.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=sean@geanix.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).