From: Peter Korsgaard <jacmet@sunsite.dk>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-mtd@lists.infradead.org, Michel Pollet <buserror@gmail.com>
Subject: Re: [MTD] [NAND] S3C2410: Added a kerneldoc for s3c2410_nand_set
Date: Tue, 02 Jun 2009 21:36:35 +0200 [thread overview]
Message-ID: <87ws7u2zss.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1243705298-21814-9-git-send-email-ben-linux@fluff.org> (Ben Dooks's message of "Sat\, 30 May 2009 18\:41\:35 +0100")
>>>>> "Ben" == Ben Dooks <ben-linux@fluff.org> writes:
Hi,
Ben> diff --git a/arch/arm/plat-s3c/include/plat/nand.h b/arch/arm/plat-s3c/include/plat/nand.h
Ben> index 9855467..350ec95 100644
Ben> --- a/arch/arm/plat-s3c/include/plat/nand.h
Ben> +++ b/arch/arm/plat-s3c/include/plat/nand.h
Ben> @@ -10,17 +10,19 @@
Ben> * published by the Free Software Foundation.
Ben> */
Ben> -/* struct s3c2410_nand_set
Ben> +/**
Ben> + * struct s3c2410_nand_set - define a set of one or more nand chips
Ben> + * @disable_ecc: Entirely disable ECC - Dangerous
Ben> + * @nr_chips: Number of chips in this set
Ben> + * @nr_partitions: Number of partitions pointed to be partitoons (or zero)
s/partitoons/partitions/ - And the text sounds pretty confusing to
me. What about
Number of struct mtd_partitions pointed to by partitions (or zero)
Yes, I know it won't fit in 80 chars.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-06-02 19:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-30 17:41 S3C2410 NAND controller updates Ben Dooks
2009-05-30 17:41 ` [MTD] [NAND] S3C2410: Move to using platform device table Ben Dooks
2009-05-30 17:41 ` [MTD] [NAND] S3C2410: Basic kerneldoc comment updates Ben Dooks
2009-05-30 17:41 ` [MTD] [NAND] S3C2410: NAND ECC by chip rather than global Ben Dooks
2009-05-30 17:41 ` [MTD] [NAND] S3C2410: Small colon cleanup Ben Dooks
2009-05-30 17:41 ` [MTD] [NAND] S3C2410: Uninitialised variable cleanup Ben Dooks
2009-05-30 17:41 ` [MTD] [NAND] S3C2410: Fix CFG debug order Ben Dooks
2009-05-30 17:41 ` [MTD] [NAND] S3C2410: Allow commandline partition processing Ben Dooks
2009-05-30 17:41 ` [MTD] [NAND] S3C2410: Added a kerneldoc for s3c2410_nand_set Ben Dooks
2009-05-30 17:41 ` [MTD] [NAND] S3C2410: Allow the machine code to get the BBT table from NAND Ben Dooks
2009-05-30 17:41 ` [MTD] [NAND] S3C2410: Deal with unaligned lengths in S3C2440 buffer read/write Ben Dooks
2009-05-30 17:41 ` [MTD] [NAND] S3C2410: Use DIV_ROUND_UP Ben Dooks
2009-06-02 19:36 ` Peter Korsgaard [this message]
2009-06-02 22:55 ` [MTD] [NAND] S3C2410: Added a kerneldoc for s3c2410_nand_set Ben Dooks
2009-06-01 5:47 ` [MTD] [NAND] S3C2410: Move to using platform device table Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws7u2zss.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=ben-linux@fluff.org \
--cc=buserror@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox