From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa1.microchip.iphmx.com ([68.232.147.91]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gL3YG-0000zQ-ID for linux-mtd@lists.infradead.org; Fri, 09 Nov 2018 09:58:10 +0000 From: To: , , , , , CC: , Subject: Re: [PATCH v3 1/2] mtd: spi-nor: Make sure SFDP-based 4B_OPCODE support detection works correctly Date: Fri, 9 Nov 2018 09:57:52 +0000 Message-ID: <89439290-50ec-0a2a-a50b-c917f7e36ea4@microchip.com> References: <20181031144504.19405-1-boris.brezillon@bootlin.com> In-Reply-To: <20181031144504.19405-1-boris.brezillon@bootlin.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <35CBD0CA0359284A813A459510626ADA@namprd11.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , DQoNCk9uIDEwLzMxLzIwMTggMDQ6NDUgUE0sIEJvcmlzIEJyZXppbGxvbiB3cm90ZToNCj4gU29t ZSBmbGFzaF9pbmZvIGVudHJpZXMgaGF2ZSB0aGUgU1BJX05PUl80Ql9PUENPREVTIGZsYWcgc2V0 IHRvIGxldCB0aGUNCj4gY29yZSBrbm93IHRoYXQgdGhlIGZsYXNoIHN1cHBvcnRzIDRCIG9wY29k ZS4gV2hpbGUgdGhpcyBzb2x1dGlvbiB3b3Jrcw0KPiBmaW5lIGZvciBpZC1iYXNlZCBjYXBzIGRl dGVjdGlvbiwgaXQgZG9lc24ndCB3b3JrIHRoYXQgd2VsbCB3aGVuIHJlbHlpbmcNCj4gb24gU0ZE UC1iYXNlZCBjYXBzIGRldGVjdGlvbi4gTGV0J3MgYWRkIGFuIFNOT1JfRl80Ql9PUENPREVTIGZs YWcgc28gdGhhdA0KPiBzcGlfbm9yX3BhcnNlX2JmcHQoKSBjYW4gYWRkIGl0IHdoZW4gdGhlIEJG UFRfRFdPUkQxX0FERFJFU1NfQllURVMNCj4gZmllbGQgaXMgc2V0IHRvIEJGUFRfRFdPUkQxX0FE RFJFU1NfQllURVNfNF9PTkxZLg0KPiANCj4gUmVwb3J0ZWQtYnk6IEFsZXhhbmRyZSBCZWxsb25p IDxhbGV4YW5kcmUuYmVsbG9uaUBib290bGluLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogQm9yaXMg QnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9vdGxpbi5jb20+DQo+IFRlc3RlZC1ieTogQWxl eGFuZHJlIEJlbGxvbmkgPGFsZXhhbmRyZS5iZWxsb25pQGJvb3RsaW4uY29tPg0KDQpSZXZpZXdl ZC1ieTogVHVkb3IgQW1iYXJ1cyA8dHVkb3IuYW1iYXJ1c0BtaWNyb2NoaXAuY29tPg0KDQo+IC0t LQ0KPiBDaGFuZ2VzIGluIHYzOg0KPiAtIENsZWFyIFNOT1JfRl80Ql9PUENPREVTIGZsYWcgd2hl biBTRkRQIGZhaWxzDQo+IC0gQWRkIEFsZXhhbmRyZSBSLWINCj4gDQo+IENoYW5nZXMgaW4gdjI6 DQo+IC0gRml4IHRoZSBjb21taXQgbWVzc2FnZQ0KPiAtIEZpeCB0aGUgLT5hZGRyX3dpZHRoIGNo ZWNrDQo+IC0gQWRkIGEgY29tbWEgYXQgdGhlIGVuZCBvZiB0aGUgU05PUl9GXzRCX09QQ09ERVMg ZGVmaW5pdGlvbg0KPiAtLS0NCj4gIGRyaXZlcnMvbXRkL3NwaS1ub3Ivc3BpLW5vci5jIHwgMTIg KysrKysrKysrLS0tDQo+ICBpbmNsdWRlL2xpbnV4L210ZC9zcGktbm9yLmggICB8ICAxICsNCj4g IDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCj4gDQo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9zcGktbm9yL3NwaS1ub3IuYyBiL2RyaXZlcnMvbXRk L3NwaS1ub3Ivc3BpLW5vci5jDQo+IGluZGV4IDNlNTRlMzE4ODljNy4uNzk4OTE1YjVjMmIwIDEw MDY0NA0KPiAtLS0gYS9kcml2ZXJzL210ZC9zcGktbm9yL3NwaS1ub3IuYw0KPiArKysgYi9kcml2 ZXJzL210ZC9zcGktbm9yL3NwaS1ub3IuYw0KPiBAQCAtMjY0Myw2ICsyNjQzLDcgQEAgc3RhdGlj IGludCBzcGlfbm9yX3BhcnNlX2JmcHQoc3RydWN0IHNwaV9ub3IgKm5vciwNCj4gIAkJYnJlYWs7 DQo+ICANCj4gIAljYXNlIEJGUFRfRFdPUkQxX0FERFJFU1NfQllURVNfNF9PTkxZOg0KPiArCQlu b3ItPmZsYWdzIHw9IFNOT1JfRl80Ql9PUENPREVTOw0KPiAgCQlub3ItPmFkZHJfd2lkdGggPSA0 Ow0KPiAgCQlicmVhazsNCj4gIA0KPiBAQCAtMzI1Miw2ICszMjUzLDcgQEAgc3RhdGljIGludCBz cGlfbm9yX2luaXRfcGFyYW1zKHN0cnVjdCBzcGlfbm9yICpub3IsDQo+ICANCj4gIAkJaWYgKHNw aV9ub3JfcGFyc2Vfc2ZkcChub3IsICZzZmRwX3BhcmFtcykpIHsNCj4gIAkJCW5vci0+YWRkcl93 aWR0aCA9IDA7DQo+ICsJCQlub3ItPmZsYWdzICY9IH5TTk9SX0ZfNEJfT1BDT0RFUzsNCj4gIAkJ CS8qIHJlc3RvcmUgcHJldmlvdXMgZXJhc2UgbWFwICovDQo+ICAJCQltZW1jcHkoJm5vci0+ZXJh c2VfbWFwLCAmcHJldl9tYXAsDQo+ICAJCQkgICAgICAgc2l6ZW9mKG5vci0+ZXJhc2VfbWFwKSk7 DQo+IEBAIC0zNTU0LDcgKzM1NTYsNyBAQCBzdGF0aWMgaW50IHNwaV9ub3JfaW5pdChzdHJ1Y3Qg c3BpX25vciAqbm9yKQ0KPiAgDQo+ICAJaWYgKChub3ItPmFkZHJfd2lkdGggPT0gNCkgJiYNCj4g IAkgICAgKEpFREVDX01GUihub3ItPmluZm8pICE9IFNOT1JfTUZSX1NQQU5TSU9OKSAmJg0KPiAt CSAgICAhKG5vci0+aW5mby0+ZmxhZ3MgJiBTUElfTk9SXzRCX09QQ09ERVMpKSB7DQo+ICsJICAg ICEobm9yLT5mbGFncyAmIFNOT1JfRl80Ql9PUENPREVTKSkgew0KPiAgCQkvKg0KPiAgCQkgKiBJ ZiB0aGUgUkVTRVQjIHBpbiBpc24ndCBob29rZWQgdXAgcHJvcGVybHksIG9yIHRoZSBzeXN0ZW0N Cj4gIAkJICogb3RoZXJ3aXNlIGRvZXNuJ3QgcGVyZm9ybSBhIHJlc2V0IGNvbW1hbmQgaW4gdGhl IGJvb3QNCj4gQEAgLTM1ODgsNyArMzU5MCw3IEBAIHZvaWQgc3BpX25vcl9yZXN0b3JlKHN0cnVj dCBzcGlfbm9yICpub3IpDQo+ICAJLyogcmVzdG9yZSB0aGUgYWRkcmVzc2luZyBtb2RlICovDQo+ ICAJaWYgKChub3ItPmFkZHJfd2lkdGggPT0gNCkgJiYNCj4gIAkgICAgKEpFREVDX01GUihub3It PmluZm8pICE9IFNOT1JfTUZSX1NQQU5TSU9OKSAmJg0KPiAtCSAgICAhKG5vci0+aW5mby0+Zmxh Z3MgJiBTUElfTk9SXzRCX09QQ09ERVMpICYmDQo+ICsJICAgICEobm9yLT5mbGFncyAmIFNOT1Jf Rl80Ql9PUENPREVTKSAmJg0KPiAgCSAgICAobm9yLT5mbGFncyAmIFNOT1JfRl9CUk9LRU5fUkVT RVQpKQ0KPiAgCQlzZXRfNGJ5dGUobm9yLCBub3ItPmluZm8sIDApOw0KPiAgfQ0KPiBAQCAtMzc0 NiwxMSArMzc0OCwxNSBAQCBpbnQgc3BpX25vcl9zY2FuKHN0cnVjdCBzcGlfbm9yICpub3IsIGNv bnN0IGNoYXIgKm5hbWUsDQo+ICAJCW5vci0+YWRkcl93aWR0aCA9IDQ7DQo+ICAJCWlmIChKRURF Q19NRlIoaW5mbykgPT0gU05PUl9NRlJfU1BBTlNJT04gfHwNCj4gIAkJICAgIGluZm8tPmZsYWdz ICYgU1BJX05PUl80Ql9PUENPREVTKQ0KPiAtCQkJc3BpX25vcl9zZXRfNGJ5dGVfb3Bjb2Rlcyhu b3IsIGluZm8pOw0KPiArCQkJbm9yLT5mbGFncyB8PSBTTk9SX0ZfNEJfT1BDT0RFUzsNCj4gIAl9 IGVsc2Ugew0KPiAgCQlub3ItPmFkZHJfd2lkdGggPSAzOw0KPiAgCX0NCj4gIA0KPiArCWlmIChu b3ItPmFkZHJfd2lkdGggPT0gNCAmJg0KPiArCSAgICBub3ItPmZsYWdzICYgU05PUl9GXzRCX09Q Q09ERVMpDQo+ICsJCXNwaV9ub3Jfc2V0XzRieXRlX29wY29kZXMobm9yLCBpbmZvKTsNCj4gKw0K PiAgCWlmIChub3ItPmFkZHJfd2lkdGggPiBTUElfTk9SX01BWF9BRERSX1dJRFRIKSB7DQo+ICAJ CWRldl9lcnIoZGV2LCAiYWRkcmVzcyB3aWR0aCBpcyB0b28gbGFyZ2U6ICV1XG4iLA0KPiAgCQkJ bm9yLT5hZGRyX3dpZHRoKTsNCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvbXRkL3NwaS1u b3IuaCBiL2luY2x1ZGUvbGludXgvbXRkL3NwaS1ub3IuaA0KPiBpbmRleCA3ZjBjNzMwMzU3NWUu LjViYzc1MTEwZDVlYSAxMDA2NDQNCj4gLS0tIGEvaW5jbHVkZS9saW51eC9tdGQvc3BpLW5vci5o DQo+ICsrKyBiL2luY2x1ZGUvbGludXgvbXRkL3NwaS1ub3IuaA0KPiBAQCAtMjM2LDYgKzIzNiw3 IEBAIGVudW0gc3BpX25vcl9vcHRpb25fZmxhZ3Mgew0KPiAgCVNOT1JfRl9SRUFEWV9YU1JfUkRZ CT0gQklUKDQpLA0KPiAgCVNOT1JfRl9VU0VfQ0xTUgkJPSBCSVQoNSksDQo+ICAJU05PUl9GX0JS T0tFTl9SRVNFVAk9IEJJVCg2KSwNCj4gKwlTTk9SX0ZfNEJfT1BDT0RFUwk9IEJJVCg3KSwNCj4g IH07DQo+ICANCj4gIC8qKg0KPiANCg==