linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: "Nikunj Kela (nkela)" <nkela@cisco.com>,
	Richard Weinberger <richard.weinberger@gmail.com>
Cc: "linux-mtd @ lists . infradead . org"
	<linux-mtd@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>
Subject: Re: [PATCH] jffs2: implement mount option to configure endianness
Date: Thu, 08 Nov 2018 19:47:08 +0000	[thread overview]
Message-ID: <897867ec09af82ca76c642b48ad23a7f08838dcf.camel@infradead.org> (raw)
In-Reply-To: <B1D7CC34-C9D3-4745-94A1-3F713C1CB216@cisco.com>

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

On Thu, 2018-11-08 at 18:01 +0000, Nikunj Kela (nkela) wrote:
>     But we can hypothesise and handwave about it until the cows come home;
>     I'd like to see a real test of whether it actually makes a difference
>     that we care about.
>     
>     If it does, one option might be to just build separate versions of
>     scan.c for each endianness, since that's the critical path we care
>     about.
> 
> I wonder if this feature is really that important that we need to duplicate the drivers.
> Also, it might take some time for me to find some device that I can run the tests with and without this patch.

Hm?

# modprobe mtdram size=16384
# mount -tjffs2 mtd0 /mnt
# cp -av .git /mnt # until it fills up
# umount /mnt
# perf record mount -tjffs2 mtd0 /mnt

On my desktop 'perf' only gets about 12 samples from that, so it's not
ideal. But you can make the mtdram device bigger, use something other
than my shiny new laptop, and use a higher sample frequency from 'perf'
and you should be able to get some vaguely meaningful results.


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]

  parent reply	other threads:[~2018-11-08 19:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 21:49 [PATCH] jffs2: implement mount option to configure endianness Nikunj Kela
2018-11-07  9:05 ` David Woodhouse
2018-11-07  9:16   ` Joakim Tjernlund
2018-11-07 16:12     ` David Woodhouse
2018-11-07 17:33       ` Daniel Walker
2018-11-07 17:58         ` David Woodhouse
2018-11-07 18:41           ` Joakim Tjernlund
2018-11-08 15:25             ` Christoph Hellwig
2018-11-07 19:21           ` Daniel Walker
2018-11-07 18:04   ` Nikunj Kela (nkela)
2018-11-07 18:14     ` Richard Weinberger
2018-11-08  8:11       ` David Woodhouse
2018-11-08 18:01         ` Nikunj Kela (nkela)
2018-11-08 18:50           ` Joakim Tjernlund
2018-11-08 19:47           ` David Woodhouse [this message]
2018-11-12 21:43             ` Daniel Walker
2018-11-12 22:50               ` Daniel Walker
2018-11-12 23:11                 ` David Woodhouse
2018-11-12 23:40                   ` Daniel Walker
2018-11-12 23:43                     ` David Woodhouse
2018-11-13  0:06                       ` Daniel Walker
2018-11-13 21:01                       ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=897867ec09af82ca76c642b48ad23a7f08838dcf.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nkela@cisco.com \
    --cc=richard.weinberger@gmail.com \
    --cc=xe-linux-external@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).