From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Mitch Davis" <mjd-linux-mtd@afork.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: mtd-utils: fec.c uses bcopy()
Date: Tue, 7 Oct 2008 21:02:49 -0400 [thread overview]
Message-ID: <8bd0f97a0810071802t52bc60fs6a230e30d7ed1c8f@mail.gmail.com> (raw)
In-Reply-To: <8956d4ca0810071727i63554837k923a0091b3ef9bd0@mail.gmail.com>
On Tue, Oct 7, 2008 at 20:27, Mitch Davis wrote:
> I use buildroot to build my embedded Linux. My run-time library is
> uClibc, which doesn't provide bcopy().
actually it does. you just disabled support for it.
> fec.c in mtd-utils uses bcopy(), so mtd-utils doesn't compile for me.
> I'd like to fix this.
>
> - Should I rewrite fec.c so it uses memcpy instead?
> - Should I just add #define NEED_BCOPY to fec.c?
> - Should I leave fec.c unchanged and add -DNEED_BCOPY to the Makefile
> (which would be passed to every compile?)
a simple sed can fix the code as the only difference between bcopy()
and memcpy() is the argument order. ifdef's are pointless/ugly in
this case.
-mike
next prev parent reply other threads:[~2008-10-08 1:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 0:27 mtd-utils: fec.c uses bcopy() Mitch Davis
2008-10-08 1:02 ` Mike Frysinger [this message]
2008-10-08 2:36 ` Mitch Davis
2008-10-08 2:38 ` Mike Frysinger
2008-10-08 4:56 ` Mitch Davis
2008-10-08 5:07 ` Mike Frysinger
2008-10-08 6:06 ` Mitch Davis
2008-10-08 6:08 ` Artem Bityutskiy
2008-10-08 6:23 ` Mike Frysinger
2008-10-08 12:43 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0810071802t52bc60fs6a230e30d7ed1c8f@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mjd-linux-mtd@afork.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox