From: David Woodhouse <dwmw2@infradead.org>
To: Jarkko Lavinen <jlavi@iki.fi>
Cc: linux-mtd@lists.infradead.org, alan@lxorguk.ukuu.org.uk
Subject: Re: complete_and_exit() problem
Date: Tue, 04 Sep 2001 09:25:09 +0100 [thread overview]
Message-ID: <9062.999591909@redhat.com> (raw)
In-Reply-To: <20010903155842.A19349@kosh.hut.fi>
jlavi@iki.fi said:
> The garbage collection thread crashes when I unmount JFFS2. The
> filesystem is empry and I only mount it and then unmount it. I am
> using kernel 2.4.8ac12 with rmk1 patch for ARM cpu.
> I traced the exeution to complete_and_exit(), then to complete(), then
> to __wake_up_common(). In __wake_up_common() there is a loop
<deletia -
http://lists.infradead.org/pipermail/linux-mtd/2001-September/003117.html >
> I tried replacing
> - if (comp)
> + if (comp && comp->wait.task_list.next)
> in complete_and_exit(). I don't know if it is the right way to do it,
> but at least the garbage gollection thread stopped crashing.
Looks like the list_head is uninitialised - we're in complete()
before anything's ever called init_completion().
ISTR this was the reason I bailed out on doing a quick fix for -ac before
disappearing to OLS.
--
dwmw2
prev parent reply other threads:[~2001-09-04 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-03 12:58 complete_and_exit() problem Jarkko Lavinen
2001-09-04 8:25 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9062.999591909@redhat.com \
--to=dwmw2@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jlavi@iki.fi \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox