From: David Woodhouse <dwmw2@infradead.org>
To: David Vrabel <dvrabel@arcom.co.uk>
Cc: mtd@infradead.org
Subject: Re: Messages produced by cfi_probe.c and cfi_cmdset_0001.c
Date: Thu, 03 Aug 2000 16:47:01 +0100 [thread overview]
Message-ID: <9202.965317621@cygnus.co.uk> (raw)
In-Reply-To: <39899405.CAB92AA4@arcom.co.uk>
dvrabel@arcom.co.uk said:
> cfi_probe.c and cfi_cmdset_0001.c both produce large quantities of
> output when probing. (eg all of the CFI query data). Is is necessary?
> Can I remove it (comment it out,#ifdef, debug only messages etc.)?
It's only there because it came long before the actual access routines, and
it make me happy to think that the code could do something useful :)
By all means, wrap it in #if 0
> Also, in cfi_cmdset_0001.c in cfi_intelext_write_{2_by_8,1_by_16}_buffe
> rs() we always write a full buffer even if we have less than a buffer
> to write. This affects performace (particularly when writing short
> <32byte buffers). Is there a reason why this is done like this?
Laziness. Please do fix it.
--
dwmw2
To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org
prev parent reply other threads:[~2000-08-03 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-08-03 15:47 Messages produced by cfi_probe.c and cfi_cmdset_0001.c David Vrabel
2000-08-03 15:47 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9202.965317621@cygnus.co.uk \
--to=dwmw2@infradead.org \
--cc=dvrabel@arcom.co.uk \
--cc=mtd@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox