From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Yang Li <yang.lee@linux.alibaba.com>, <richard@nod.at>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] ubifs: Fix some kernel-doc comments
Date: Wed, 12 Jul 2023 15:32:35 +0800 [thread overview]
Message-ID: <94b243cb-da53-a3d4-7986-60e3be65a761@huawei.com> (raw)
In-Reply-To: <20230712071200.78575-1-yang.lee@linux.alibaba.com>
在 2023/7/12 15:12, Yang Li 写道:
> Add description of @time and @flags in ubifs_update_time().
>
> to silence the warnings:
> fs/ubifs/file.c:1383: warning: Function parameter or member 'time' not described in 'ubifs_update_time'
> fs/ubifs/file.c:1383: warning: Function parameter or member 'flags' not described in 'ubifs_update_time'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5848
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> fs/ubifs/file.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
> index 436b27d7c58f..5e86ef1be698 100644
> --- a/fs/ubifs/file.c
> +++ b/fs/ubifs/file.c
> @@ -1375,6 +1375,8 @@ static inline int mctime_update_needed(const struct inode *inode,
> /**
> * ubifs_update_time - update time of inode.
> * @inode: inode to update
> + * @time: timespec structure to hold the current time value
> + * @flags: file time flag
flags: time updating control flag determines updating which time fields
of @inode
> *
> * This function updates time of the inode.
> */
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-07-12 7:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 7:12 [PATCH -next] ubifs: Fix some kernel-doc comments Yang Li
2023-07-12 7:32 ` Zhihao Cheng [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-02 5:52 Yang Li
2022-06-02 6:36 ` Zhihao Cheng
2022-07-08 9:17 ` Zhihao Cheng
2022-07-08 11:14 ` Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94b243cb-da53-a3d4-7986-60e3be65a761@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=abaci@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox