Re: [PATCH -next] ubifs: Fix some kernel-doc comments

Zhihao Cheng
2022-06-02T06:37:45Z

Hi, maybe we should change them like this:

> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
> index 75dab0ae3939..16857d4e9aa8 100644
> --- a/fs/ubifs/journal.c
> +++ b/fs/ubifs/journal.c
> @@ -1201,9 +1201,12 @@ int ubifs_jnl_xrename(struct ubifs_info *c, const struct inode *fst_dir,
> * ubifs_jnl_rename - rename a directory entry.
> * @c: UBIFS file-system description object
> * @old_dir: parent inode of directory entry to rename
> - * @old_dentry: directory entry to rename
> + * @old_inode: parent inode to rename

old_inode: directory entry's inode to rename
> + * @old_nm: name of old inode to rename

old_nm: name of the old directory entry to rename
> * @new_dir: parent inode of directory entry to rename
> - * @new_dentry: new directory entry (or directory entry to replace)
> + * @new_inode: new inode to rename

new_inode: new directory entry's inode (or directory entry's inode to
replace)
> + * @new_nm: name of new inode to rename

new_name: name of the new directory entry to rename
> + * @whiteout: whiteout inode
> * @sync: non-zero if the write-buffer has to be synchronized
> *
> * This function implements the re-name operation which may involve writing up