From: Michael Walle <michael@walle.cc>
To: Hongwei Zhang <hongweiz@ami.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids
Date: Wed, 30 Jun 2021 15:56:41 +0200 [thread overview]
Message-ID: <95865068f95f7d75a67e8eb3ab4fe906@walle.cc> (raw)
In-Reply-To: <20210629150846.21547-2-hongweiz@ami.com>
Hi Hongwei,
Am 2021-06-29 17:08, schrieb Hongwei Zhang:
> Add some Micron M45PEx flash memeories into the IDs table.
Did you test all these flashes?
> Fixes: dd1e9367157f900616f (ARM: dts: everest: Add phase corrections
> for
> eMMC)
Bogus Fixes tag. First, I cannot find this commit id, which tree is
that? Secondly, adding new flash ids don't fix anything, esp not
something related to eMMC.
>
> Signed-off-by: Hongwei Zhang <hongweiz@ami.com>
> ---
> drivers/mtd/spi-nor/micron-st.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/micron-st.c
> b/drivers/mtd/spi-nor/micron-st.c
> index ef3695080710..379b14e339ff 100644
> --- a/drivers/mtd/spi-nor/micron-st.c
> +++ b/drivers/mtd/spi-nor/micron-st.c
> @@ -95,8 +95,12 @@ static const struct flash_info st_parts[] = {
> { "m25p128-nonjedec", INFO(0, 0, 256 * 1024, 64, 0) },
>
> { "m45pe10", INFO(0x204011, 0, 64 * 1024, 2, 0) },
> + { "m45pe20", INFO(0x204012, 0, 64 * 1024, 4, 0) },
> + { "m45pe40", INFO(0x204013, 0, 64 * 1024, 8, 0) },
> { "m45pe80", INFO(0x204014, 0, 64 * 1024, 16, 0) },
> { "m45pe16", INFO(0x204015, 0, 64 * 1024, 32, 0) },
> + { "m45pe32", INFO(0x204016, 0, 64 * 1024, 64, 0) },
> + { "m45pe64", INFO(0x204017, 0, 64 * 1024, 128, 0) },
>
> { "m25pe20", INFO(0x208012, 0, 64 * 1024, 4, 0) },
> { "m25pe80", INFO(0x208014, 0, 64 * 1024, 16, 0) },
--
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-06-30 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 15:08 [PATCH v1 0/1] mtd: spi-nor: Add some M45PEx ids Hongwei Zhang
2021-06-29 15:08 ` [PATCH v1 1/1] " Hongwei Zhang
2021-06-30 13:56 ` Michael Walle [this message]
2021-06-30 18:20 ` Hongwei Zhang
2021-07-01 10:02 ` Michael Walle
2021-07-01 15:18 ` Hongwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95865068f95f7d75a67e8eb3ab4fe906@walle.cc \
--to=michael@walle.cc \
--cc=hongweiz@ami.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=p.yadav@ti.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox