From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 600E6C10DCE for ; Thu, 12 Mar 2020 06:28:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A7EB20650 for ; Thu, 12 Mar 2020 06:28:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WszfXWmE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A7EB20650 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=53wJHSATxMKjrVj9GTGezBVaWYqiUfJytQKhWHf2hy0=; b=WszfXWmEGXIM+5 /ou2+rTM59nF6KRd9MnWFjFHqWbMwunAV7Ab/9TPW0Oaqigq6pfoeF1QZUIeIZk+1ALFU8B5C/DLE L0tabkPZK2Ps6jQ5ZNobH68l46RXCoYXughuj5X9E0cEtUxvrL0uLsVJAfuzJw/EkvdOxi7zDxdjF ymEhQhBEQZGE5xAQBPpAqEgeRHer1iX0e/5NiELoKd9XLwOo61M5kL0J0n82SOg4PNYZ7sTNHPzs3 bXAeiVp0wo3FYGbrvrKqZYGmy4qLO0W46ebqUVl0ZY6FpgpkUkR9R/d3Y4C+TY//2TGehmbdsCpX/ eZ4YSRU/Z0HTGCJCli9A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCHK1-000324-OK; Thu, 12 Mar 2020 06:27:57 +0000 Received: from smtprelay0207.hostedemail.com ([216.40.44.207] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCHJy-000316-NY for linux-mtd@lists.infradead.org; Thu, 12 Mar 2020 06:27:56 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 72080182CED5B; Thu, 12 Mar 2020 06:27:50 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: point06_441a962f90223 X-Filterd-Recvd-Size: 3157 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Thu, 12 Mar 2020 06:27:47 +0000 (UTC) Message-ID: <969ea500cfd66fa2fc32e8d1e9c6126710d16813.camel@perches.com> Subject: Re: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough; From: Joe Perches To: Miquel Raynal Date: Wed, 11 Mar 2020 23:26:04 -0700 In-Reply-To: <20200311084052.3ca3c331@xps13> References: <20200311084052.3ca3c331@xps13> User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_232754_830075_5AD00F36 X-CRM114-Status: GOOD ( 12.16 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Vignesh Raghavendra , alsa-devel@alsa-project.org, David Airlie , Richard Weinberger , Mark Brown , Takashi Iwai , linux-mmc@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Paul Cercueil , Harvey Hunt , linux-mtd@lists.infradead.org, Daniel Vetter , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, 2020-03-11 at 08:40 +0100, Miquel Raynal wrote: > Hi Joe, > > Joe Perches wrote on Tue, 10 Mar 2020 21:51:27 -0700: > > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > > > Signed-off-by: Joe Perches > > --- > > drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- > > drivers/mmc/host/jz4740_mmc.c | 6 ++---- > > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- > > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++-- > > drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++-- > > sound/soc/codecs/jz4770.c | 2 +- > > 6 files changed, 9 insertions(+), 11 deletions(-) > > I like very much the new way to advertise for fallthrough statements, > but I am not willing to take any patch converting a single driver > anymore. I had too many from Gustavo when these comments had to be > inserted. I would really prefer a MTD-wide or a NAND-wide or at least a > raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/). I understand completely. This set was done to generate patches by nominally maintained subsystems. If you want something else: The easiest thing for you to do would be to run the cvt_fallthrough.pl script yourself. $ cvt_fallthrough.pl drivers/mtd/nand/raw/ That would produce: $ git diff --shortstat drivers/mtd/nand/raw 9 files changed, 18 insertions(+), 24 deletions(-) or $ cvt_fallthrough.pl drivers/mtd/ which would produce: $ git diff --shortstat drivers/mtd/ 22 files changed, 45 insertions(+), 60 deletions(-) cheers, Joe ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/