From: <Takahiro.Kuwano@infineon.com>
To: <mwalle@kernel.org>, <tkuw584924@gmail.com>,
<linux-mtd@lists.infradead.org>
Cc: <tudor.ambarus@linaro.org>, <pratyush@kernel.org>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<Bacem.Daassi@infineon.com>
Subject: RE: [PATCH] mtd: spi-nor: remove unused NO_OP_CHIP_ERASE flag
Date: Fri, 17 Apr 2026 00:27:19 +0000 [thread overview]
Message-ID: <97a94aa30860409fabe0ce97dbc92cd8@infineon.com> (raw)
In-Reply-To: <DHUIOTOESC19.117TN18W5AV86@kernel.org>
> Hi,
>
> On Thu Apr 16, 2026 at 11:03 AM CEST, tkuw584924 wrote:
> > --- a/drivers/mtd/spi-nor/core.h
> > +++ b/drivers/mtd/spi-nor/core.h
> > @@ -124,23 +124,22 @@
> > /* Keep these in sync with the list in debugfs.c */
> > enum spi_nor_option_flags {
> > SNOR_F_HAS_SR_TB = BIT(0),
> > - SNOR_F_NO_OP_CHIP_ERASE = BIT(1),
>
> Can we just drop this line and leave the rest as is? It's already
> hard to follow any development in spi-nor due to code churn. I don't
> think one hole in the flags hurts. The next new flag can then just
> reuse it.
>
> -michael
>
Sounds fine to me. With a placeholder like this?
/* NEW FLAG HERE : BIT(1) */
Thanks,
Takahiro
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-04-17 0:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 9:03 [PATCH] mtd: spi-nor: remove unused NO_OP_CHIP_ERASE flag tkuw584924
2026-04-16 9:15 ` Tudor Ambarus
2026-04-16 9:32 ` Tudor Ambarus
2026-04-16 10:46 ` Michael Walle
2026-04-17 0:27 ` Takahiro.Kuwano [this message]
2026-04-17 6:30 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a94aa30860409fabe0ce97dbc92cd8@infineon.com \
--to=takahiro.kuwano@infineon.com \
--cc=Bacem.Daassi@infineon.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tkuw584924@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox