cfi_probe module usage count when insmod physmap.o fails

cfi_probe module usage count when insmod physmap.o fails

[Vipin Malik]

When insmod physmap.o fails, it does not decrement the usage count of
cfi_probe.o

This results in an ever increasing usage count for each "try" of insmod
physmap.o

The problem that I encountered is that trying to unload cfi_probe module
to add some debug printk's was not possible.

I solved the problem with an extra line in physmap.c right before it
exits because do_cfi_probe() failed that decrements
the cfi_probe module usage count as thus:

 inter_module_put("cfi_probe");

This works. Anyone see any problems with it? If not can we change
physmap.c with this change?

Thanks

Vipin



To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org

Re: cfi_probe module usage count when insmod physmap.o fails

[David Woodhouse]

vmalik@danielind.com said:
>  I solved the problem with an extra line in physmap.c right before it
> exits because do_cfi_probe() failed that decrements the cfi_probe
> module usage count as thus:

>  inter_module_put("cfi_probe");

Probably right. It was all working fine when it was using 
get_module_symbol(). Now, I think I'm going to just give up and switch over 
to hard dependencies on the symbols. 


--
dwmw2




To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org