From: Marek Vasut <marek.vasut@gmail.com>
To: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>, linux-mtd@lists.infradead.org
Cc: boris.brezillon@free-electrons.com, cyrille.pitchen@wedev4u.fr,
computersforpeace@gmail.com, han.xu@nxp.com, festevam@gmail.com,
frieder.schrempf@exceet.de, prabhakar.kushwaha@nxp.com,
suresh.gupta@nxp.com
Subject: Re: [PATCH v10 2/2] mtd: fsl-quadspi: fix init AHB read in fsl_qspi_nor_setup()
Date: Tue, 10 Apr 2018 11:25:09 +0200 [thread overview]
Message-ID: <9aaa221a-0d0c-d001-9cc9-477d3506c429@gmail.com> (raw)
In-Reply-To: <1523349348-20778-3-git-send-email-yogeshnarayan.gaur@nxp.com>
On 04/10/2018 10:35 AM, Yogesh Gaur wrote:
> Move AHB read initialize in fsl_qspi_nor_setup().
>
> In file spi-nor.c, func spi_nor_scan() calls nor->read() thru
> spi_nor_read_sfdp() API.
>
> Presently, fsl_qspi_init_ahb_read() called from fsl_qspi_nor_setup_last().
> Func fsl_qspi_probe() calls spi_nor_scan() first and then calls
> fsl_qspi_nor_setup_last().
>
> When nor->read() being called from inside spi_nor_read_sfdp(), QSPI cntlr
> AHB mode initialization is not yet done results in data read error.
>
> Initialize AHB read inside fsl_qspi_nor_setup().
Please run the commit message through aspell or somesuch, hint : func,
thru, cntlr .
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-04-10 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 8:35 [PATCH v10 0/2] mtd: fsl-quadspi: add support to create dynamic LUT entry Yogesh Gaur
2018-04-10 8:35 ` [PATCH v10 1/2] " Yogesh Gaur
2018-04-10 9:23 ` Marek Vasut
2018-04-10 8:35 ` [PATCH v10 2/2] mtd: fsl-quadspi: fix init AHB read in fsl_qspi_nor_setup() Yogesh Gaur
2018-04-10 9:25 ` Marek Vasut [this message]
2018-04-10 8:44 ` [PATCH v10 0/2] mtd: fsl-quadspi: add support to create dynamic LUT entry Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aaa221a-0d0c-d001-9cc9-477d3506c429@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@exceet.de \
--cc=han.xu@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=prabhakar.kushwaha@nxp.com \
--cc=suresh.gupta@nxp.com \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox