Re: [PATCH v6 3/3] mtd: cfi_cmdset_0002: Rename chip_ready variables and add ID definition

From: Tokunori Ikegami <ikegami.t@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: linux-mtd@lists.infradead.org,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v6 3/3] mtd: cfi_cmdset_0002: Rename chip_ready variables and add ID definition
Date: Thu, 24 Mar 2022 02:18:37 +0900	[thread overview]
Message-ID: <9fd54dbc-a4a9-9aac-3f8f-d0443da6c162@gmail.com> (raw)
In-Reply-To: <20220323175345.619ba991@xps13>

Hi Miquel-san,

On 2022/03/24 1:53, Miquel Raynal wrote:
> Hi Tokunori,
>
> ikegami.t@gmail.com wrote on Thu, 24 Mar 2022 01:46:00 +0900:
>
>> Hi Miquel-san,
>>
>> On 2022/03/23 17:02, Miquel Raynal wrote:
>>> Hi Tokunori,
>>>
>>> ikegami.t@gmail.com wrote on Wed, 23 Mar 2022 08:49:52 +0900:
>>>   
>>>> The definition is for the S29GL064N model number 01, 02, V1 and V2.
>>> Please keep resending the entire series.
>> I see. (In the past it was mentioned as not necessary to send all patches if a patch fixed of series.)
> Generally speaking, while you have not been notified that a patch got
> applied, it's best to resend it as part of your series.
Thanks for your advice. I see and understood as it seems that it was 
okay if I resent as the version 5 3/3 patch but not version 6 3/3 patch.
>
>>>   
>>>> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
>>>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>>>> Cc: Richard Weinberger <richard@nod.at>
>>>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>>>> Cc: linux-mtd@lists.infradead.org
>>> You don't need all these Cc there, just add them when sending
>>> everything with git-format-patch. I believe you can use these fields
>>> just for "extra" people which are not notably expected.
>> Will do as so. By the way it was commented on the version 1 patch by Vignesh-san as below so added CC maintainers by version 2 patch.
>>    > Please CC maintainers from
>>    >
>>    > ./scripts/get_maintainer.pl -f drivers/mtd/chips/cfi_cmdset_0002.c
>>    >
>>    > Else, patch would not get attention in time.
> And Vignesh is right. You should Cc the maintainers, but you can do
> that by using git-send-email --cc foo --cc bar. Adding Cc: lines with
> all the maintainers in the patch does not really help and just grows
> the commit log for no reason.

Yes agreed with this.

Regards,
Ikegami

>
>
>
> Thanks,
> Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/