From: Brian Norris <computersforpeace@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 2/2] mtd: onenand/samsung.c: fix build error
Date: Fri, 17 Jun 2011 10:10:42 -0700 [thread overview]
Message-ID: <BANLkTi=MiT1PrcJMdAfegTg74BQYNHC2fw@mail.gmail.com> (raw)
In-Reply-To: <1308298294.13535.3.camel@phoenix>
Hi,
On Fri, Jun 17, 2011 at 1:11 AM, Axel Lin <axel.lin@gmail.com> wrote:
> - err = mtd_device_parse_register(&info->mtd, NULL, 0,
> + err = mtd_device_parse_register(onenand->mtd, NULL, 0,
> pdata ? pdata->parts : NULL,
> pdata ? pdata->nr_parts : 0);
Wouldn't it be just the same (and shorter) to use "mtd" instead of
onenand->mtd? Like:
err = mtd_device_parse_register(mtd, NULL, 0,
pdata ? pdata->parts : NULL,
pdata ? pdata->nr_parts : 0);
Brian
next prev parent reply other threads:[~2011-06-17 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 8:09 [PATCH 1/2] mtd: onenand/omap2.c: fix build error Axel Lin
2011-06-17 8:11 ` [PATCH 2/2] mtd: onenand/samsung.c: " Axel Lin
2011-06-17 17:10 ` Brian Norris [this message]
2011-06-22 5:07 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=MiT1PrcJMdAfegTg74BQYNHC2fw@mail.gmail.com' \
--to=computersforpeace@gmail.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=axel.lin@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).