Re: [PATCH 1/6] [MTD-UTILS] nandwrite: Qualifier Clean-up

[Grant Erickson <gerickson@nuovations.com>]

On 9/9/08 6:23 AM, Enrico Scholz wrote:
> Grant Erickson <gerickson@nuovations.com> writes:
>> +static const char *mtd_device, *img;
> 
> would it be possible to split this into two declarations?  I
> really don't know if 'img' points to a constant or non-constant
> char...

As currently implemented, both mtd_device and img point to effectively
read-only information. That is, there is no need to modify or to attempt to
modify what they point to.

Should that change in the future, these can be declared differently;
however, for the present, the const qualifier accurately represents program
intent.

>> -int main(int argc, char **argv)
>> +int main(int argc, char * const argv[])
> 
> Is this really correct?  C standard mentions only
> 
>                int main(void) { /* ... */ }
>                int main(int argc, char *argv[]) { /* ... */ }
> 
> as program entry points.  I suggest to cast 'argv' to a corresponding
> data type when it is used.

Those are certainly the two most common prototypes for main. However,
because main has no prototype, adding the const qualifier simply conveys
current program intent. That is, the strings pointed to by argv are not
modified.

Regards,

Grant