From: Richard Weinberger <richard.weinberger@gmail.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Subodh Nijsure <snijsure@grid-net.com>
Subject: Re: [PATCH v2 1/7] ubifs: Remove unused security xattr handler
Date: Tue, 22 Sep 2015 14:41:12 +0200 [thread overview]
Message-ID: <CAFLxGvxrm1E696hSJ6GtnC-V16uWFWBU036a-Aak8PW43us69A@mail.gmail.com> (raw)
In-Reply-To: <1442924812-9384-2-git-send-email-agruenba@redhat.com>
On Tue, Sep 22, 2015 at 2:26 PM, Andreas Gruenbacher
<agruenba@redhat.com> wrote:
> Ubifs installs a security xattr handler in sb->s_xattr but doesn't use the
> generic_{get,set,list,remove}xattr inode operations needed for processing
> this list of attribute handlers; the handler is never called. Instead,
> ubifs uses its own xattr handlers which also process security xattrs.
>
> Remove the dead code.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> Cc: Subodh Nijsure <snijsure@grid-net.com>
Should this go through the ubifs tree or do you carry it?
Anyway,
Reviewed-by: Richard Weinberger <richard@nod.at>
--
Thanks,
//richard
next prev parent reply other threads:[~2015-09-22 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442924812-9384-1-git-send-email-agruenba@redhat.com>
2015-09-22 12:26 ` [PATCH v2 1/7] ubifs: Remove unused security xattr handler Andreas Gruenbacher
2015-09-22 12:41 ` Richard Weinberger [this message]
2015-09-22 12:47 ` Andreas Gruenbacher
2015-09-22 12:26 ` [PATCH v2 3/7] jffs2: Add missing capability check for listing trusted xattrs Andreas Gruenbacher
2015-10-04 6:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLxGvxrm1E696hSJ6GtnC-V16uWFWBU036a-Aak8PW43us69A@mail.gmail.com \
--to=richard.weinberger@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=agruenba@redhat.com \
--cc=dedekind1@gmail.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=snijsure@grid-net.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).