From: Jeff Harris <jefftharris@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org, Jeff Harris <jharris@westell.com>
Subject: Re: [PATCH] jffs2: Re-enable write-buffering after filesystem sync
Date: Mon, 4 Aug 2014 14:02:19 -0400 [thread overview]
Message-ID: <CAGMfbUMua7uZR16G1-r4+DwoPP2k5C3TQDNQkvbCO4RFwRm-+A@mail.gmail.com> (raw)
In-Reply-To: <20140801191340.GN18016@ZenIV.linux.org.uk>
On Fri, Aug 1, 2014 at 3:13 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> Why do we need ->wbuf_queued, anyway? It's not as if queue_delayed_work()
> wouldn't do the right thing - if the sucker already has WORK_STRUCT_PENDING_BIT
> set it'll simply do nothing. And it won't spend much time finding that
> out - in fact, it'll be cheaper than what we do right now.
>
> IOW, how about the following (completely untested):
>
I tested the patch against our 3.13 device, and it appears to resolve
the original
write-buffering after sync problem we were having. I did not do any
other regression
testing, though.
Jeff
prev parent reply other threads:[~2014-08-04 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 16:06 [PATCH] jffs2: Re-enable write-buffering after filesystem sync Jeff Harris
2014-08-01 16:56 ` Al Viro
2014-08-01 17:15 ` Jeff Harris
2014-08-01 19:13 ` Al Viro
2014-08-04 18:02 ` Jeff Harris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGMfbUMua7uZR16G1-r4+DwoPP2k5C3TQDNQkvbCO4RFwRm-+A@mail.gmail.com \
--to=jefftharris@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jharris@westell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).