linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Brian Foster <brian.foster@maximintegrated.com>
Cc: Linux MTD <linux-mtd@lists.infradead.org>
Subject: Re: [Q] What is struct mtd_partition.ecclayout & who uses it?
Date: Wed, 7 Oct 2015 23:44:25 +0100	[thread overview]
Message-ID: <CAN8TOE_PxTXdVj6YNG+t0vujrTf1kai0KBV8bM2j0OKGZqoT6Q@mail.gmail.com> (raw)
In-Reply-To: <1893578.doJlQXXNMH@laclwks004>

On Wed, Oct 7, 2015 at 2:11 PM, Brian Foster
<brian.foster@maximintegrated.com> wrote:
>
>   In `struct mtd_partition' there is an undocumented field
>   `.ecclayout' which (modulo a name/type change) has existed since
>   Linus's original GIT commit 1da177e4c3f4 ("Linux-2.6.12-rc2").
>
>   However, with one trivial exception, I can_NOT_ find any users
>   of this field.  The exception is it is initialized to NULL in
>   mtd_add_partition().
>
>   Indeed, a trial build (of v3.10 for my system) with that field
>   and its one known usage /*commented-out*/ succeeded, proving
>   that *IF* it is used at all, it's probably by some specific
>   NAND(-controller?) driver(s?).
>
>   Any idea which one(s?)?
>
>   Offhand, this looks like a long-dead something, with the only
>   clew being the comment (in <linux/mtd/partitions.h>):
>
>      /* out of band layout for this partition (NAND only) */

Looks like you've found a dead field. Not too surprising.

If it's not used in mainline, it's ripe for killing. Patches welcome!

Regards,
Brian

      reply	other threads:[~2015-10-07 22:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 13:11 [Q] What is struct mtd_partition.ecclayout & who uses it? Brian Foster
2015-10-07 22:44 ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN8TOE_PxTXdVj6YNG+t0vujrTf1kai0KBV8bM2j0OKGZqoT6Q@mail.gmail.com \
    --to=computersforpeace@gmail.com \
    --cc=brian.foster@maximintegrated.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).