linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [Q] What is struct mtd_partition.ecclayout & who uses it?
@ 2015-10-07 13:11 Brian Foster
  2015-10-07 22:44 ` Brian Norris
  0 siblings, 1 reply; 2+ messages in thread
From: Brian Foster @ 2015-10-07 13:11 UTC (permalink / raw)
  To: Linux MTD


  In `struct mtd_partition' there is an undocumented field
  `.ecclayout' which (modulo a name/type change) has existed since
  Linus's original GIT commit 1da177e4c3f4 ("Linux-2.6.12-rc2").

  However, with one trivial exception, I can_NOT_ find any users
  of this field.  The exception is it is initialized to NULL in
  mtd_add_partition().

  Indeed, a trial build (of v3.10 for my system) with that field
  and its one known usage /*commented-out*/ succeeded, proving
  that *IF* it is used at all, it's probably by some specific
  NAND(-controller?) driver(s?).

  Any idea which one(s?)?

  Offhand, this looks like a long-dead something, with the only
  clew being the comment (in <linux/mtd/partitions.h>):

     /* out of band layout for this partition (NAND only) */

cheers!
	-blf-

-- 
Brian Foster
Principal MTS, Software        |  La Ciotat, France
Maxim Integrated               |  http://www.maximintegrated.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Q] What is struct mtd_partition.ecclayout & who uses it?
  2015-10-07 13:11 [Q] What is struct mtd_partition.ecclayout & who uses it? Brian Foster
@ 2015-10-07 22:44 ` Brian Norris
  0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2015-10-07 22:44 UTC (permalink / raw)
  To: Brian Foster; +Cc: Linux MTD

On Wed, Oct 7, 2015 at 2:11 PM, Brian Foster
<brian.foster@maximintegrated.com> wrote:
>
>   In `struct mtd_partition' there is an undocumented field
>   `.ecclayout' which (modulo a name/type change) has existed since
>   Linus's original GIT commit 1da177e4c3f4 ("Linux-2.6.12-rc2").
>
>   However, with one trivial exception, I can_NOT_ find any users
>   of this field.  The exception is it is initialized to NULL in
>   mtd_add_partition().
>
>   Indeed, a trial build (of v3.10 for my system) with that field
>   and its one known usage /*commented-out*/ succeeded, proving
>   that *IF* it is used at all, it's probably by some specific
>   NAND(-controller?) driver(s?).
>
>   Any idea which one(s?)?
>
>   Offhand, this looks like a long-dead something, with the only
>   clew being the comment (in <linux/mtd/partitions.h>):
>
>      /* out of band layout for this partition (NAND only) */

Looks like you've found a dead field. Not too surprising.

If it's not used in mainline, it's ripe for killing. Patches welcome!

Regards,
Brian

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-07 22:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-07 13:11 [Q] What is struct mtd_partition.ecclayout & who uses it? Brian Foster
2015-10-07 22:44 ` Brian Norris

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).