From: Michal Suchanek <hramrach@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Heiner Kallweit" <hkallweit1@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Han Xu" <han.xu@freescale.com>,
"Boris Brezillon" <boris.brezillon@free-electrons.com>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
"Stephen Warren" <swarren@nvidia.com>,
"Andrew F. Davis" <afd@ti.com>, "Marek Vasut" <marex@denx.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Gabor Juhos" <juhosg@openwrt.org>,
"Bean Huo 霍斌斌" <beanhuo@micron.com>,
"Furquan Shaikh" <furquan@google.com>,
"MTD Maling List" <linux-mtd@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH v5 08/10] spi: expose master transfer size limitation.
Date: Wed, 2 Dec 2015 10:55:16 +0100 [thread overview]
Message-ID: <CAOMqctTbJVpxbGaRHhfNGfN6gVCZBQkiVRLe1Cm8LeGzwtamcQ@mail.gmail.com> (raw)
In-Reply-To: <20151201195816.GS1929@sirena.org.uk>
On 1 December 2015 at 20:58, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Dec 01, 2015 at 04:51:06PM -0000, Michal Suchanek wrote:
>> On some SPI controllers it is not feasible to transfer arbitrary amount
>> of data at once.
>>
>> When the limit on transfer size is a few kilobytes at least it makes
>> sense to use the SPI hardware rather than reverting to gpio driver.
>
>> + /*
>> + * on some hardware transfer size may be constrained
>> + * the limit may depend on device transfer settings
>> + */
>> + size_t (*max_transfer_size)(struct spi_device *spi);
>
> Heiner submitted a *very* similar patch just now with a straight
> variable plus accessor instead of a function and using a name with _msg.
> I'm ambivalent on the implementation but prefer the naming here since
> that's more the limitation we're trying to express I think (some
> hardware does have limiations about multple transfers too). Can the two
> of you come up with something that works for both of you?
Sorry, missed there is a patch because it shows in the middle of the
discussion for me.
I don't really care which one it is so long as I can get the last
patch in this series based on it.
Thanks
Michal
next prev parent reply other threads:[~2015-12-02 9:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 16:51 [PATCH v5 00/10] add error checking to spi-nor read and write Michal Suchanek
2015-12-01 16:51 ` [PATCH v5 01/10] mtd: spi-nor: change return value of read/write Michal Suchanek
2015-12-01 16:51 ` [PATCH v5 03/10] mtd: fsl-quadspi: return amount of data read/written or error Michal Suchanek
2015-12-01 16:51 ` [PATCH v5 02/10] mtd: m25p80: return amount of data transferred or error in read/write Michal Suchanek
2015-12-01 16:51 ` [PATCH v5 04/10] mtd: spi-nor: check return value from read/write Michal Suchanek
2015-12-01 16:51 ` [PATCH v5 07/10] mtd: spi-nor: add read loop Michal Suchanek
2015-12-01 16:51 ` [PATCH v5 05/10] mtd: spi-nor: stop passing around retlen Michal Suchanek
2015-12-01 16:51 ` [PATCH v5 06/10] mtd: spi-nor: simplify write loop Michal Suchanek
2015-12-01 16:51 ` [PATCH v5 09/10] spi: fsl-espi: expose maximum transfer size limit Michal Suchanek
2015-12-01 16:51 ` [PATCH v5 08/10] spi: expose master transfer size limitation Michal Suchanek
2015-12-01 19:58 ` Mark Brown
2015-12-01 21:07 ` Heiner Kallweit
2015-12-01 21:31 ` Mark Brown
2015-12-02 9:55 ` Michal Suchanek [this message]
2015-12-01 23:12 ` Mark Brown
2015-12-02 9:38 ` Michal Suchanek
2015-12-04 14:30 ` Martin Sperl
2015-12-04 16:45 ` Michal Suchanek
2015-12-07 20:18 ` Mark Brown
2015-12-01 16:51 ` [PATCH v5 10/10] spi: m25p80: read in spi_max_transfer_size chunks Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMqctTbJVpxbGaRHhfNGfN6gVCZBQkiVRLe1Cm8LeGzwtamcQ@mail.gmail.com \
--to=hramrach@gmail.com \
--cc=afd@ti.com \
--cc=beanhuo@micron.com \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=furquan@google.com \
--cc=han.xu@freescale.com \
--cc=hkallweit1@gmail.com \
--cc=javier@osg.samsung.com \
--cc=juhosg@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marex@denx.de \
--cc=mika.westerberg@linux.intel.com \
--cc=swarren@nvidia.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).