* Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap
[not found] ` <20151009221651.32203.63446.stgit@dwillia2-desk3.jf.intel.com>
@ 2015-10-12 17:58 ` Brian Norris
2015-10-12 20:31 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2015-10-12 17:58 UTC (permalink / raw)
To: Dan Williams
Cc: linux-kernel, linux-arch, David Woodhouse, linux-arm-kernel,
linux-mtd
You missed linux-mtd again. Please use scripts/get_maintainer.pl next
time to at least get the relevant mailing list(s). (The individual CC's
are not always necessary, but the subsystem lists definitely are.)
Brian
On Fri, Oct 09, 2015 at 06:16:51PM -0400, Dan Williams wrote:
> In preparation for deprecating ioremap_cache() convert its usage in
> pxa2xx-flash to memremap.
>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> [brian: also convert iounmap to memunmap]
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/mtd/maps/pxa2xx-flash.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
> index 12fa75df5008..5ff6cc5b4844 100644
> --- a/drivers/mtd/maps/pxa2xx-flash.c
> +++ b/drivers/mtd/maps/pxa2xx-flash.c
> @@ -71,8 +71,8 @@ static int pxa2xx_flash_probe(struct platform_device *pdev)
> info->map.name);
> return -ENOMEM;
> }
> - info->map.cached =
> - ioremap_cache(info->map.phys, info->map.size);
> + info->map.cached = memremap(info->map.phys, info->map.size,
> + MEMREMAP_WB);
> if (!info->map.cached)
> printk(KERN_WARNING "Failed to ioremap cached %s\n",
> info->map.name);
> @@ -111,7 +111,7 @@ static int pxa2xx_flash_remove(struct platform_device *dev)
> map_destroy(info->mtd);
> iounmap(info->map.virt);
> if (info->map.cached)
> - iounmap(info->map.cached);
> + memunmap(info->map.cached);
> kfree(info);
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap
2015-10-12 17:58 ` [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Brian Norris
@ 2015-10-12 20:31 ` Brian Norris
2015-10-12 20:36 ` Dan Williams
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2015-10-12 20:31 UTC (permalink / raw)
To: Dan Williams
Cc: linux-kernel, linux-arch, David Woodhouse, linux-arm-kernel,
linux-mtd
On Mon, Oct 12, 2015 at 10:58:03AM -0700, Brian Norris wrote:
> You missed linux-mtd again. Please use scripts/get_maintainer.pl next
> time to at least get the relevant mailing list(s). (The individual CC's
> are not always necessary, but the subsystem lists definitely are.)
Anyway, pushed to l2-mtd.git.
Brian
> On Fri, Oct 09, 2015 at 06:16:51PM -0400, Dan Williams wrote:
> > In preparation for deprecating ioremap_cache() convert its usage in
> > pxa2xx-flash to memremap.
> >
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Brian Norris <computersforpeace@gmail.com>
> > [brian: also convert iounmap to memunmap]
> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > ---
> > drivers/mtd/maps/pxa2xx-flash.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
> > index 12fa75df5008..5ff6cc5b4844 100644
> > --- a/drivers/mtd/maps/pxa2xx-flash.c
> > +++ b/drivers/mtd/maps/pxa2xx-flash.c
> > @@ -71,8 +71,8 @@ static int pxa2xx_flash_probe(struct platform_device *pdev)
> > info->map.name);
> > return -ENOMEM;
> > }
> > - info->map.cached =
> > - ioremap_cache(info->map.phys, info->map.size);
> > + info->map.cached = memremap(info->map.phys, info->map.size,
> > + MEMREMAP_WB);
> > if (!info->map.cached)
> > printk(KERN_WARNING "Failed to ioremap cached %s\n",
> > info->map.name);
> > @@ -111,7 +111,7 @@ static int pxa2xx_flash_remove(struct platform_device *dev)
> > map_destroy(info->mtd);
> > iounmap(info->map.virt);
> > if (info->map.cached)
> > - iounmap(info->map.cached);
> > + memunmap(info->map.cached);
> > kfree(info);
> > return 0;
> > }
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap
2015-10-12 20:31 ` Brian Norris
@ 2015-10-12 20:36 ` Dan Williams
0 siblings, 0 replies; 3+ messages in thread
From: Dan Williams @ 2015-10-12 20:36 UTC (permalink / raw)
To: Brian Norris
Cc: linux-kernel@vger.kernel.org, linux-arch, David Woodhouse,
linux-arm-kernel@lists.infradead.org, linux-mtd
On Mon, Oct 12, 2015 at 1:31 PM, Brian Norris
<computersforpeace@gmail.com> wrote:
> On Mon, Oct 12, 2015 at 10:58:03AM -0700, Brian Norris wrote:
>> You missed linux-mtd again. Please use scripts/get_maintainer.pl next
>> time to at least get the relevant mailing list(s). (The individual CC's
>> are not always necessary, but the subsystem lists definitely are.)
>
> Anyway, pushed to l2-mtd.git.
>
Thanks Brian, I'll watch out for that next time.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-12 20:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151009221537.32203.5867.stgit@dwillia2-desk3.jf.intel.com>
[not found] ` <20151009221651.32203.63446.stgit@dwillia2-desk3.jf.intel.com>
2015-10-12 17:58 ` [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Brian Norris
2015-10-12 20:31 ` Brian Norris
2015-10-12 20:36 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).