public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Xi Wang <xi.wang@gmail.com>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] jffs2: refactor csize in jffs2_do_read_inode_internal()
Date: Mon, 23 Apr 2012 02:58:38 -0400	[thread overview]
Message-ID: <CF33F54F-FFF7-4F44-98DC-374C16C29A68@gmail.com> (raw)
In-Reply-To: <1335160854.28267.30.camel@brekeke>

On Apr 23, 2012, at 2:00 AM, Artem Bityutskiy wrote:
> 
> I think JFFS2 has its own limit on the maximum size of the symlink
> target. Probably it is PAGE_CACHE_SIZE, but not sure.

Is it this one?

fs/jffs2/dir.c:297

static int jffs2_symlink (struct inode *dir_i, struct dentry *dentry, const char *target)
{
        ...
        int targetlen = strlen(target);

        /* FIXME: If you care. We'd need to use frags for the target
           if it grows much more than this */
        if (targetlen > 254)
                return -ENAMETOOLONG;
	...

}

I guess the magic value 254 is JFFS2_MAX_NAME_LEN defined in
include/linux/jffs2.h.

- xi

      reply	other threads:[~2012-04-23  6:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09 22:42 [PATCH] jffs2: refactor csize in jffs2_do_read_inode_internal() Xi Wang
2012-04-21 14:12 ` Artem Bityutskiy
2012-04-21 16:44   ` Xi Wang
2012-04-22 11:57 ` Artem Bityutskiy
2012-04-23  5:43   ` Xi Wang
2012-04-23  6:00     ` Artem Bityutskiy
2012-04-23  6:58       ` Xi Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CF33F54F-FFF7-4F44-98DC-374C16C29A68@gmail.com \
    --to=xi.wang@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox