From: "Michael Walle" <mwalle@kernel.org>
To: "Muhammad Usama Anjum" <usama.anjum@collabora.com>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Takahiro Kuwano" <Takahiro.Kuwano@infineon.com>
Cc: <kernel@collabora.com>, <kernel-janitors@vger.kernel.org>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mtd: spi-nor: core: correct type of i
Date: Mon, 04 Mar 2024 10:16:53 +0100 [thread overview]
Message-ID: <CZKUPDY8GTHC.BQ9KN9FR2R0H@kernel.org> (raw)
In-Reply-To: <20240304090103.818092-1-usama.anjum@collabora.com>
[-- Attachment #1.1: Type: text/plain, Size: 430 bytes --]
On Mon Mar 4, 2024 at 10:01 AM CET, Muhammad Usama Anjum wrote:
> The i should be signed to find out the end of the loop. Otherwise,
> i >= 0 is always true and loop becomes infinite. Make its type to be
> int.
>
> Fixes: 6a9eda34418f ("mtd: spi-nor: core: set mtd->eraseregions for non-uniform erase map")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: Michael Walle <mwalle@kernel.org>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-03-04 9:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 9:01 [PATCH v2] mtd: spi-nor: core: correct type of i Muhammad Usama Anjum
2024-03-04 9:11 ` Tudor Ambarus
2024-03-04 9:16 ` Michael Walle [this message]
2024-03-04 10:11 ` Dan Carpenter
2024-03-04 10:32 ` AngeloGioacchino Del Regno
2024-03-05 1:10 ` Takahiro Kuwano
2024-03-11 17:11 ` Muhammad Usama Anjum
2024-03-12 12:14 ` Pratyush Yadav
2024-03-12 12:16 ` Muhammad Usama Anjum
2024-03-13 22:23 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZKUPDY8GTHC.BQ9KN9FR2R0H@kernel.org \
--to=mwalle@kernel.org \
--cc=Takahiro.Kuwano@infineon.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=usama.anjum@collabora.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox