linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Walle" <mwalle@kernel.org>
To: "Simon Richter" <simon@sinic.eu>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Pratyush Yadav" <pratyush@kernel.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
	<linux-mtd@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Cc: "Marcus Folkesson" <marcus.folkesson@gmail.com>
Subject: Re: [PATCH] mtd: spi-nor: atmel: add at25dn011
Date: Fri, 17 Oct 2025 08:44:18 +0200	[thread overview]
Message-ID: <DDKE72QORJS2.29XWZ4U0T0K4I@kernel.org> (raw)
In-Reply-To: <20251017060529.21169-1-simon@sinic.eu>


[-- Attachment #1.1: Type: text/plain, Size: 1269 bytes --]

Hi Simon,

On Fri Oct 17, 2025 at 8:05 AM CEST, Simon Richter wrote:
> Add AT25DN011 with 1Mbit.
> Used on multiple custom boards and tested with this patch.

Could you add your testing to the next version of your patch (below
a "---" line). See also [1].

>
> Link: https://www.renesas.com/en/document/dst/at25dn011-datasheet?r=1608506

Newer flash and no SFDP :|

> Signed-off-by: Simon Richter <simon@sinic.eu>
> ---
>  drivers/mtd/spi-nor/atmel.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c
> index 82c592f0a1e1..0c2908bce0bc 100644
> --- a/drivers/mtd/spi-nor/atmel.c
> +++ b/drivers/mtd/spi-nor/atmel.c
> @@ -171,6 +171,11 @@ static const struct flash_info atmel_nor_parts[] = {
>  		.name = "at45db081d",
>  		.size = SZ_1M,
>  		.no_sfdp_flags = SECT_4K,
> +	}, {
> +		.id = SNOR_ID(0x1f, 0x42, 0x00),
> +		.name = "at25dn011",

No .name please, the ID is enough. We've deprecated the use of a
name.

> +		.size = SZ_128K,
> +		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ

missing trailing comma.

-michael

>  	}, {
>  		.id = SNOR_ID(0x1f, 0x42, 0x16),
>  		.name = "at25sl321",

[1] https://docs.kernel.org/driver-api/mtd/spi-nor.html

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2025-10-17  6:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17  6:05 [PATCH] mtd: spi-nor: atmel: add at25dn011 Simon Richter
2025-10-17  6:44 ` Michael Walle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DDKE72QORJS2.29XWZ4U0T0K4I@kernel.org \
    --to=mwalle@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marcus.folkesson@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=simon@sinic.eu \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).