Re: [PATCH v2 0/3] mtd: spi-nor: winbond: Fix protection handling

["Michael Walle" <mwalle@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1545 bytes --]

Hi Eliav,

On Wed Feb 18, 2026 at 3:35 PM CET, Eliav Farber wrote:
> This series fixes block protection handling for the following Winbond
> SPI-NOR devices:
>  - w25q256jwm
>  - w25q256jw
>  - w25q64jvm
>
> The devices do not correctly describe their Status Register layout and
> protection capabilities (locking flags, TB bit, BP bit configuration).
> As a result, the spi-nor core rejects protection requests and locking
> operations fail with -EINVAL, e.g.:
>
>   flash_lock -l /dev/mtd29
>   flash_lock: error!: could not lock device: /dev/mtd29
>   error 22 (Invalid argument)
>
> Update the device flags to match the actual hardware behavior so that
> locking and unlocking regions work correctly.
>
> All changes were validated using flash_lock on the affected devices.
>
> Changes in v2:
> - Remove last patch in series that added dual/quad read for w25q64jvm

Why? Unfortunately, you didn't answer my questions.

> - Added Minimum testing requirements for w25q256jwm and w25q64jvm

Thanks, but why was the w25q256jw left out?

> Eliav Farber (3):
>   mtd: spi-nor: winbond: Fix locking support for w25q256jwm
>   mtd: spi-nor: winbond: Fix locking support for w25q256jw
>   mtd: spi-nor: winbond: Fix locking support for w25q64jvm

You're supposed to pick the Reviewed-by: tags up before sending a
new version, see [1].

-michael

[1] https://docs.kernel.org/process/submitting-patches.html

>
>  drivers/mtd/spi-nor/winbond.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/