On Fri Apr 17, 2026 at 2:27 AM CEST, Takahiro.Kuwano wrote:
>> Hi,
>> 
>> On Thu Apr 16, 2026 at 11:03 AM CEST, tkuw584924 wrote:
>> > --- a/drivers/mtd/spi-nor/core.h
>> > +++ b/drivers/mtd/spi-nor/core.h
>> > @@ -124,23 +124,22 @@
>> >  /* Keep these in sync with the list in debugfs.c */
>> >  enum spi_nor_option_flags {
>> >  	SNOR_F_HAS_SR_TB	= BIT(0),
>> > -	SNOR_F_NO_OP_CHIP_ERASE	= BIT(1),
>> 
>> Can we just drop this line and leave the rest as is? It's already
>> hard to follow any development in spi-nor due to code churn. I don't
>> think one hole in the flags hurts. The next new flag can then just
>> reuse it.
>> 
>> -michael
>> 
> Sounds fine to me. With a placeholder like this?
> /* NEW FLAG HERE : BIT(1) */

You could add a comment above the enum. Something like. "This could
contain holes, if adding a new flag use the first free spot." 

-michael