Re: [PATCH v1 7/8] mtd: spi-nor: push the rollback mechanism into the sfdp module

From: "Michael Walle" <mwalle@kernel.org>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: "Pratyush Yadav" <pratyush@kernel.org>,
	"Takahiro Kuwano" <takahiro.kuwano@infineon.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	<linux-mtd@lists.infradead.org>,
	"Cheng Ming Lin" <chengminglin@mxic.com.tw>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 7/8] mtd: spi-nor: push the rollback mechanism into the sfdp module
Date: Mon, 06 Jul 2026 16:34:20 +0200	[thread overview]
Message-ID: <DJRK9ORBDZH8.1YM083YAEDN62@kernel.org> (raw)
In-Reply-To: <874iickxki.fsf@bootlin.com>

[-- Attachment #1.1: Type: text/plain, Size: 1138 bytes --]

On Mon Jul 6, 2026 at 4:22 PM CEST, Miquel Raynal wrote:
> On 03/07/2026 at 16:29:18 +02, Michael Walle <mwalle@kernel.org> wrote:
>
>> Right now, the core is handling the rollback of the parameters. But it
>> doesn't have the knowledge what has to be rolled back. And in fact,
>> havent rolled back everything. Push it down to the called function and
>> make it mandatory, that this function has no side effects if it fails.
>>
>> Funny enough, there is a comment in the SFDP table handing code that
>
> handling?                                                ^

yeah ;)

>> each table parser is responsible to roll back any changes. But none of
>> them did. So while add it, expand the logic to that and roll it back for
>> them. There is one simple rule though:
>>
>>   SFDP parsing and fixups may only modify the spi_nor_flash_parameters.
>
> Ok.
>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Btw Sashiko found a problem with the new rollback logic [1]. So
expect that there will be at least a v2.

-michael

[1] https://sashiko.dev/#/patchset/20260703143003.1809579-1-mwalle%40kernel.org

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/