From: Xi Wang <xi.wang@gmail.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: linux-mtd@lists.infradead.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 1/2] jffs2: validate symlink size in jffs2_do_read_inode_internal()
Date: Sun, 29 Apr 2012 17:45:54 -0400 [thread overview]
Message-ID: <FD35DFE2-7E03-4B87-AAC6-16002F1B3A0B@gmail.com> (raw)
In-Reply-To: <1335714291.1942.15.camel@koala>
On Apr 29, 2012, at 11:44 AM, Artem Bityutskiy wrote:
>
> I think your commit message is a not general enough because it talks
> about 0xFFFFFFFF value, but there may be any other large value as well.
> I've added the following cause to the commit message and pushed both
> patches to l2-mtd.git, thanks! Please, verify.
>
> The clause:
>
> "Artem: we actually validate csize by checking CRC, so this 0xFFs cannot
> come from empty flash region. But I guess an attacker could feed JFFS2
> an image with random csize value, including 0xFFs."
Looks good to me. Thanks!
- xi
prev parent reply other threads:[~2012-04-29 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 18:45 [PATCH v2 1/2] jffs2: validate symlink size in jffs2_do_read_inode_internal() Xi Wang
2012-04-25 18:45 ` [PATCH v2 2/2] jffs2: refactor csize usage " Xi Wang
2012-04-29 15:44 ` [PATCH v2 1/2] jffs2: validate symlink size " Artem Bityutskiy
2012-04-29 21:45 ` Xi Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FD35DFE2-7E03-4B87-AAC6-16002F1B3A0B@gmail.com \
--to=xi.wang@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox