public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: "Chuck Meade" <chuckmeade@mindspring.com>
To: <linux-mtd@lists.infradead.org>
Subject: [MTD] cmdlineparts.c: fix to allow partition offset zero for any partition
Date: Mon, 6 Mar 2006 12:38:46 -0500	[thread overview]
Message-ID: <IIEEICKJLNEPBBDJICNGIEIAKDAA.chuckmeade@mindspring.com> (raw)

Here is the patch I sent earlier today (that email is pending moderator
approval) in the MTD-approved patch format.  Sorry I didn't see this MTD
patch format earlier.

[MTD] cmdlineparts.c: fix to allow partition offset zero for any partition

The cmdlinepart.c logic treats a partition offset that has been explicitly
specified as zero the same as an unspecified offset.  This causes the
partitioning logic to fail if your partition that starts at 0x0 is not the
first partition listed in your cmdline partitions.

For example, if you have several partitions, and you want the third partition
to be an all-encompassing partition covering the whole device, then you
would give it offset 0x0.  The cmdlinepart.c logic treats this the same as
if you had not specified an offset, and instead tries to start the third
partition after the end of your second partition.  This is because the logic
uses zero as the "unspecified offset" value.  However, zero is not a good
choice for "unspecified offset" -- it is quite valid as a "specified" offset.

The attached patch defines the "unspecified offset" value as 0xffffffff and
makes the changes needed to support partitions that explicitly start at
offset 0x0, but are not necessarily listed first on the cmdline.

From: Chuck Meade <chuckmeade@mindspring.com>
Signed-off-by: Chuck Meade <chuckmeade@mindspring.com>

--- cmdlinepart.c.ORIG	2006-03-05 19:34:43.000000000 -0500
+++ cmdlinepart.c	2006-03-06 10:17:15.063475104 -0500
@@ -40,6 +40,10 @@
 #define dbg(x)
 #endif
 
+/* indicates that the offset for a partition was not specified, so start at
+ * end of previous partition.
+ */
+#define OFFSET_UNSPECIFIED 0xffffffff
 
 /* special size referring to all the remaining space in a partition */
 #define SIZE_REMAINING 0xffffffff
@@ -75,7 +79,7 @@ static struct mtd_partition * newpart(ch
 {
 	struct mtd_partition *parts;
 	unsigned long size;
-	unsigned long offset = 0;
+	unsigned long offset = OFFSET_UNSPECIFIED;
 	char *name;
 	int name_len;
 	unsigned char *extra_mem;
@@ -314,7 +318,7 @@ static int parse_cmdline_partitions(stru
 		{
 			for(i = 0, offset = 0; i < part->num_parts; i++)
 			{
-				if (!part->parts[i].offset)
+				if (part->parts[i].offset == OFFSET_UNSPECIFIED)
 				  part->parts[i].offset = offset;
 				else
 				  offset = part->parts[i].offset;

             reply	other threads:[~2006-03-06 17:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-06 17:38 Chuck Meade [this message]
2006-03-08  1:29 ` [MTD] cmdlineparts.c: fix to allow partition offset zero for any partition Atsushi Nemoto
2006-03-08  3:21   ` Chuck Meade
2006-03-08  5:27     ` Intel P3 flash support yh
2006-03-09 16:55       ` Nicolas Pitre
2006-03-08  7:47     ` [MTD] cmdlineparts.c: fix to allow partition offset zero for any partition Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=IIEEICKJLNEPBBDJICNGIEIAKDAA.chuckmeade@mindspring.com \
    --to=chuckmeade@mindspring.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox