From: Eric Biggers <ebiggers@kernel.org>
To: Daniel Rosenberg <drosen@google.com>
Cc: kernel-team@android.com, "Theodore Y . Ts'o" <tytso@mit.edu>,
Richard Weinberger <richard@nod.at>, Chao Yu <chao@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [PATCH v2 2/3] fscrypt: Have filesystems handle their d_ops
Date: Tue, 17 Nov 2020 10:31:17 -0800 [thread overview]
Message-ID: <X7QW9aqdF9ivHKBe@sol.localdomain> (raw)
In-Reply-To: <20201117040315.28548-3-drosen@google.com>
On Tue, Nov 17, 2020 at 04:03:14AM +0000, Daniel Rosenberg wrote:
> diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h
> index a8f7a43f031b..df2c66ca370e 100644
> --- a/include/linux/fscrypt.h
> +++ b/include/linux/fscrypt.h
> @@ -741,8 +741,9 @@ static inline int fscrypt_prepare_rename(struct inode *old_dir,
> * directory's encryption key is available, then the lookup is assumed to be by
> * plaintext name; otherwise, it is assumed to be by no-key name.
> *
> - * This also installs a custom ->d_revalidate() method which will invalidate the
> - * dentry if it was created without the key and the key is later added.
> + * After calling this function, a filesystem should ensure that its dentry
> + * operations contain fscrypt_d_revalidate if DCACHE_ENCRYPTED_NAME was set,
> + * so that the dentry can be invalidated if the key is later added.
> *
> * Return: 0 on success; -ENOENT if the directory's key is unavailable but the
> * filename isn't a valid no-key name, so a negative dentry should be created;
This should say DCACHE_NOKEY_NAME, not DCACHE_ENCRYPTED_NAME.
But more importantly, the explanation here isn't very clear. How about the
following instead:
* This will set DCACHE_NOKEY_NAME on the dentry if the lookup is by no-key
* name. In this case the filesystem must assign the dentry a dentry_operations
* which contains fscrypt_d_revalidate (or contains a d_revalidate method that
* calls fscrypt_d_revalidate), so that the dentry will be invalidated if the
* directory's encryption key is later added.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-11-17 18:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 4:03 [PATCH v2 0/3] Add support for Encryption and Casefolding in F2FS Daniel Rosenberg
2020-11-17 4:03 ` [PATCH v2 1/3] libfs: Add generic function for setting dentry_ops Daniel Rosenberg
2020-11-17 17:33 ` Theodore Y. Ts'o
2020-11-17 18:16 ` Eric Biggers
2020-11-17 18:36 ` [f2fs-dev] " Eric Biggers
2020-11-17 4:03 ` [PATCH v2 2/3] fscrypt: Have filesystems handle their d_ops Daniel Rosenberg
2020-11-17 14:03 ` Theodore Y. Ts'o
2020-11-17 17:04 ` Jaegeuk Kim
2020-11-17 17:34 ` Theodore Y. Ts'o
2020-11-17 18:31 ` Eric Biggers [this message]
2020-11-17 4:03 ` [PATCH v2 3/3] f2fs: Handle casefolding with Encryption Daniel Rosenberg
2020-11-17 18:50 ` Eric Biggers
2020-11-18 6:22 ` Daniel Rosenberg
2020-11-18 6:27 ` Eric Biggers
2020-11-17 18:53 ` [PATCH v2 0/3] Add support for Encryption and Casefolding in F2FS Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7QW9aqdF9ivHKBe@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=chao@kernel.org \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox