Re: [PATCH 3/5] block: remove the ->rq_disk field in struct request

Chaitanya Kulkarni
2021-09-28T21:22:28Z

On 9/28/21 2:11 PM, Chaitanya Kulkarni wrote:
> External email: Use caution opening links or attachments
>
>
> On 9/27/21 10:22 PM, Christoph Hellwig wrote:
>> Just use the disk attached to the request_queue instead.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> ---
>
> Please consider adding :-
>
> root@dev linux-block (for-next) # git diff drivers/mtd
> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
> index b8ae1ec14e17..f0488694afdb 100644
> --- a/drivers/mtd/mtd_blkdevs.c
> +++ b/drivers/mtd/mtd_blkdevs.c
> @@ -59,7 +59,7 @@ static blk_status_t do_blktrans_request(struct
> mtd_blktrans_ops *tr,
> }
>
> if (blk_rq_pos(req) + blk_rq_cur_sectors(req) >
> - get_capacity(req->rq_disk))
> + get_capacity(req->q->disk))
> return BLK_STS_IOERR;
>
> switch (req_op(req)) {
>

sorry for the noise, you have already done it in patch 1,
when I applied patch 1 it failed on my tree due to copy paste
error and I missed it ..