From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF8DFC433F5 for ; Thu, 25 Nov 2021 09:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QTW941Bxr27N9B2RXZ3kuH/HRGFaBl0f0sXdd/TcYns=; b=1DvZmi5vgd84YB iNJiC7gpbOna3xT6aqh9d/YdFk1MV7gg951McnHpDUmx6OqJ8f/D4Vg5QG0K2CuASOV4MfrfW0120 DDNc2zDCHOoFohMmCo397dJIPwZPYixpuQzZi9G8dAq0RNOqvGHYV4Io+KBihrJn8F29U4DEwzZVT Uv337d8BTRwCRb1S3UhzPrGW2TwJdY9dwbAJSMYThrXT1dCTKupHsMHZ9kLL9e+DHyNE2NG48Yvia TWj8gUOlbBRdkpacFm85rp0uYCs50cr2ZQxiCoTAFXUw009jSKvjJXOZzW2NeFJ46YuEg7zL8B/Yz y1aKJOuwMzbLKUXYONOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqB6w-006vA6-Oi; Thu, 25 Nov 2021 09:32:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqB6t-006v99-Jm for linux-mtd@lists.infradead.org; Thu, 25 Nov 2021 09:32:08 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 563B76108B; Thu, 25 Nov 2021 09:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637832727; bh=uvwK6xkBqc0Znk7K/Ky4+OAVTT2Tgux5Kci1XFX8G7s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A22aw7jpeZpx4drvuc79ExTAHz6VeHUzufIvszz7ZaVx6vozqrYdGuHHB4ir0DkuK 4DosN3et1ryeH2sSo99GI46FHAMGrBjfPt0qtOD8B9VjSAsNRfJ1lLuEMyJyhlHoGv DiaytizYSHxweQu8nu9uC6rol+SgVSBSEjRjgUudS+4ouGtjQrdd8dEfOOvDI0M0tk Lwu8GSBC4nwXXs69WFKA9Kb21m1eFmHQxaZcig1TBhzh82FgRakL2sHa7/Okr2+Wwy DmKF7mojkI+nVpmahE4/oqR+93nJWRLIZT+N2quZ9UqaNezklRPtuBCcngVQgzq7Oj 3e7fssOTS3ObQ== Date: Thu, 25 Nov 2021 15:02:02 +0530 From: Vinod Koul To: Arnd Bergmann Cc: kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, ALSA Development Mailing List , dri-devel , Bjorn Andersson , "open list:TEGRA ARCHITECTURE SUPPORT" , Thierry Reding , linux-mtd , Laurent Pinchart , linux-spi , Robert Jarzmik Subject: Re: [PATCH 07/11] dmaengine: qcom-adm: stop abusing slave_id config Message-ID: References: <20211115085403.360194-8-arnd@kernel.org> <202111251538.x6sJNCka-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_013207_696697_117EE777 X-CRM114-Status: GOOD ( 23.47 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 25-11-21, 09:25, Arnd Bergmann wrote: > On Thu, Nov 25, 2021 at 8:57 AM kernel test robot wrote: > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > >> drivers/dma/qcom/qcom_adm.c:712:18: warning: no previous prototype for function 'adm_dma_xlate' [-Wmissing-prototypes] > > struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec, > > ^ > > drivers/dma/qcom/qcom_adm.c:712:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec, > > ^ > > static > > 1 warning generated. > > I noticed this mistake slipped into v2 as well, the function needs to > be marked 'static'. > > Vinod, let me know how you want me to address this. Should I just fold > the fix (see below) > and the final Acks into the patch and send an updated pull request, or > do a complete v3 > submission? I can fold this while applying, the series lgtm, I will wait a day before applying... Thanks > > Arnd > > 8<--- > diff --git a/drivers/dma/qcom/qcom_adm.c b/drivers/dma/qcom/qcom_adm.c > index bb338b303af6..65697bee4db0 100644 > --- a/drivers/dma/qcom/qcom_adm.c > +++ b/drivers/dma/qcom/qcom_adm.c > @@ -709,8 +709,8 @@ static void adm_channel_init(struct adm_device > *adev, struct adm_chan *achan, > * > * Returns pointer to appropriate dma channel on success or NULL on error. > */ > -struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec, > - struct of_dma *ofdma) > +static struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec, > + struct of_dma *ofdma) > { > struct dma_device *dev = ofdma->of_dma_data; > struct dma_chan *chan, *candidate = NULL; -- ~Vinod ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/