Re: [PATCH] dt-bindings: Another pass removing cases of 'allOf' containing a '$ref'

Bjorn Andersson
2022-03-02T02:47:21Z

On Mon 28 Feb 13:38 PST 2022, Rob Herring wrote:

> Another pass at removing unnecessary use of 'allOf' with a '$ref'.
>
> json-schema versions draft7 and earlier have a weird behavior in that
> any keywords combined with a '$ref' are ignored (silently). The correct
> form was to put a '$ref' under an 'allOf'. This behavior is now changed
> in the 2019-09 json-schema spec and '$ref' can be mixed with other
> keywords.
>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-input@vger.kernel.org
> Cc: linux-leds@vger.kernel.org
> Cc: linux-mtd@lists.infradead.org
> Cc: netdev@vger.kernel.org
> Cc: linux-phy@lists.infradead.org
> Cc: linux-pm@vger.kernel.org
> Cc: linux-remoteproc@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-spi@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/connector/usb-connector.yaml | 3 +--
> .../bindings/display/brcm,bcm2711-hdmi.yaml | 3 +--
> .../bindings/display/bridge/adi,adv7511.yaml | 5 ++---
> .../bindings/display/bridge/synopsys,dw-hdmi.yaml | 5 ++---
> .../bindings/display/panel/display-timings.yaml | 3 +--
> .../devicetree/bindings/display/ste,mcde.yaml | 4 ++--
> .../devicetree/bindings/input/adc-joystick.yaml | 9 ++++-----
> .../bindings/leds/cznic,turris-omnia-leds.yaml | 3 +--
> .../devicetree/bindings/leds/leds-lp50xx.yaml | 3 +--
> .../devicetree/bindings/mfd/google,cros-ec.yaml | 12 ++++--------
> .../devicetree/bindings/mtd/nand-controller.yaml | 8 +++-----
> .../bindings/mtd/rockchip,nand-controller.yaml | 3 +--
> .../devicetree/bindings/net/ti,cpsw-switch.yaml | 3 +--
> .../bindings/phy/phy-stm32-usbphyc.yaml | 3 +--
> .../bindings/power/supply/sbs,sbs-manager.yaml | 4 +---
> .../bindings/remoteproc/ti,k3-r5f-rproc.yaml | 3 +--

For the remoteproc binding:

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Thanks,
Bjorn