From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBABAC433EF for ; Wed, 23 Feb 2022 17:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WvY4aVl4lzOqPzSd8laQuAna5gxUN4wcrrAYbMH1yS4=; b=0M7rL40FqlfSgx JRc3mPHdth1inA8Vf4uzxRvCecS1LGmiXmxQxlsl2OD5mXQYxcItdc351PIIiqVyIJqgh6i/uwZsO hMAHUPRy3GQl/W6HsUAb8q6ImzUXTj9Pc6n5bU0sNmNwIypJ0P3rz5x3BNlzezzQQgUtgD12my/0H zlfoK52Vo7SK0xyHsV/xgVRVPr9mvBCq6mOtF0mVzl2pvxtxbwxSzay59/Xx9alB6JAt/ECd7E8s3 h19gf5I1qpn+fgxKXacltK/eawTxZ+il+pvCPwoCHvr1MPoe80ot+kwkGDdOkiqDVtPnczEAthVjO 1epIBrM2kPpQh0lizuAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMvq8-00FbDc-6T; Wed, 23 Feb 2022 17:54:12 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMvq4-00FbCp-Uf for linux-mtd@lists.infradead.org; Wed, 23 Feb 2022 17:54:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7590D61541; Wed, 23 Feb 2022 17:54:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81F89C340E7; Wed, 23 Feb 2022 17:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645638847; bh=9cyKoELaNqypOn6SHzTC2b1tlOn9ixroF+zh6jd+RKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tGo9inj5iVBcUOYzna0Lz+mKuY/Uq3s1lV1b4qbYtaPb7GIPZ3bPxN896gGdGLWPS 7tCSMgvvQkyZQZQIEKtj3E4a6QbCG1Uz0W+o65ziGkLou0ZnfEenrqSeN7urJvzmeH vGkyllNhMfmLBSf5ThH3ia4pb1+vYoAsYPbvJi18= Date: Wed, 23 Feb 2022 18:54:05 +0100 From: Greg KH To: Florian Fainelli Cc: stable@vger.kernel.org, sashal@kernel.org, david regan , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Brian Norris , "open list:NAND FLASH SUBSYSTEM" , open list Subject: Re: [PATCH RESEND stable 4.9] mtd: rawnand: brcmnand: Fixed incorrect sub-page ECC status Message-ID: References: <20220223174431.1083-1-f.fainelli@gmail.com> <20220223174431.1083-3-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220223174431.1083-3-f.fainelli@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220223_095409_064017_C1A1BD27 X-CRM114-Status: GOOD ( 19.88 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Feb 23, 2022 at 09:44:31AM -0800, Florian Fainelli wrote: > From: david regan > > commit 36415a7964711822e63695ea67fede63979054d9 upstream > > The brcmnand driver contains a bug in which if a page (example 2k byte) > is read from the parallel/ONFI NAND and within that page a subpage (512 > byte) has correctable errors which is followed by a subpage with > uncorrectable errors, the page read will return the wrong status of > correctable (as opposed to the actual status of uncorrectable.) > > The bug is in function brcmnand_read_by_pio where there is a check for > uncorrectable bits which will be preempted if a previous status for > correctable bits is detected. > > The fix is to stop checking for bad bits only if we already have a bad > bits status. > > Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") > Signed-off-by: david regan > Reviewed-by: Florian Fainelli > Signed-off-by: Miquel Raynal > Link: https://lore.kernel.org/linux-mtd/trinity-478e0c09-9134-40e8-8f8c-31c371225eda-1643237024774@3c-app-mailcom-lxa02 > [florian: make patch apply to 4.14, file was renamed] > Signed-off-by: Florian Fainelli > --- > drivers/mtd/nand/brcmnand/brcmnand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Why is this a RESEND? What happened with the first set? thanks, greg k-h ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/