public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Sergey Shtylyov <s.shtylyov@omp.ru>,
	Dung Nguyen <dung.nguyen.zy@renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Andrew Gabbasov <andrew_gabbasov@mentor.com>,
	Mark Brown <broonie@kernel.org>,
	linux-renesas-soc@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] memory: renesas-rpc-if: Fix HF/OSPI data transfer in Manual mode
Date: Tue, 29 Mar 2022 11:56:26 +0200	[thread overview]
Message-ID: <YkLXyoHnB3EucLnA@ninjato> (raw)
In-Reply-To: <ad6ef2af754c8163f825d3a199d64f910d63f802.1648545212.git.geert+renesas@glider.be>


[-- Attachment #1.1: Type: text/plain, Size: 473 bytes --]

Hi Geert,

thank you for this update!

>   - Update comments to match changed code,
>   - Add explicit {read,write}l() for the 4/8 byte case, to increase
>     readability,
>   - Remove redundant break statements,

I really like these changes and have nothing more to add:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

I also tested writing on R-Car V3U and V3M, so:

Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Happy hacking,

   Wolfram


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2022-03-29  9:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  9:15 [PATCH v3] memory: renesas-rpc-if: Fix HF/OSPI data transfer in Manual mode Geert Uytterhoeven
2022-03-29  9:56 ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkLXyoHnB3EucLnA@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andrew_gabbasov@mentor.com \
    --cc=broonie@kernel.org \
    --cc=dung.nguyen.zy@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=s.shtylyov@omp.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox