From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Michael Walle <michael@walle.cc>, Pratyush Yadav <p.yadav@ti.com>,
Hongli Li <hongli.li@intel.com>,
linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] spi: intel: Implement dirmap hooks
Date: Wed, 20 Apr 2022 09:25:48 +0300 [thread overview]
Message-ID: <Yl+nbNCj5l7uDgH0@lahna> (raw)
In-Reply-To: <Yl6nS0kSdSGOCYM3@sirena.org.uk>
Hi Mark,
On Tue, Apr 19, 2022 at 01:12:59PM +0100, Mark Brown wrote:
> On Mon, Apr 11, 2022 at 02:31:58PM +0300, Mika Westerberg wrote:
> > Currently the driver goes over the supported opcodes list each time
> > ->exec_op() is called and finds the suitable for the given operation.
> > This consumes unnecessary amount of CPU cycles because the operation is
> > always the same. For this reason populate dirmap hooks for the driver so
> > that we cache the selected operation and then simply call it on each
> > read/write.
>
> This breaks an x86 allmodconfig build:
>
> /build/stage/linux/drivers/spi/spi-intel.c: In function ‘intel_spi_dirmap_read’:
> /build/stage/linux/drivers/spi/spi-intel.c:808:38: error: passing argument 2 of ‘iop->exec_op’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> 808 | ret = iop->exec_op(ispi, desc->mem, iop, &op);
> | ~~~~^~~~~
> | |
> | struct spi_mem *
Oh, indeed :( I have another patch adding second chip select support
that adds the parameter and then I changed the ordering, and of course
forgot to reflect that to this patch. I will fix this up and re-send.
Sorry about this.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-04-20 6:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 11:31 [PATCH 1/2] spi: intel: Fix typo in kernel-doc of intel_spi_probe() Mika Westerberg
2022-04-11 11:31 ` [PATCH 2/2] spi: intel: Implement dirmap hooks Mika Westerberg
2022-04-19 12:12 ` Mark Brown
2022-04-20 6:25 ` Mika Westerberg [this message]
2022-04-19 22:45 ` [PATCH 1/2] spi: intel: Fix typo in kernel-doc of intel_spi_probe() Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl+nbNCj5l7uDgH0@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=boris.brezillon@collabora.com \
--cc=broonie@kernel.org \
--cc=hongli.li@intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael@walle.cc \
--cc=p.yadav@ti.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox