Re: [PATCH 04/20] mm/migrate: Convert buffer_migrate_page() to buffer_migrate_folio()

kernel test robot
2022-06-07T03:39:07Z

Hi "Matthew,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.19-rc1 next-20220606]
[cannot apply to jaegeuk-f2fs/dev-test trondmy-nfs/linux-next kdave/for-next xfs-linux/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/Convert-aops-migratepage-to-aops-migrate_folio/20220607-044509
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f2906aa863381afb0015a9eb7fefad885d4e5a56
config: i386-defconfig (https://download.01.org/0day-ci/archive/20220607/202206071139.aWSx4GHH-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/96e64ba8b1be545885d89f44b1d8b968b22bdb4d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Convert-aops-migratepage-to-aops-migrate_folio/20220607-044509
git checkout 96e64ba8b1be545885d89f44b1d8b968b22bdb4d
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> mm/migrate.c:775: warning: expecting prototype for buffer_migrate_folio_noref(). Prototype was for buffer_migrate_folio_norefs() instead

vim +775 mm/migrate.c

89cb0888ca1483a Jan Kara 2018-12-28 758
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 759) /**
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 760) * buffer_migrate_folio_noref() - Migration function for folios with buffers.
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 761) * @mapping: The address space containing @src.
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 762) * @dst: The folio to migrate to.
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 763) * @src: The folio to migrate from.
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 764) * @mode: How to migrate the folio.
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 765) *
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 766) * Like buffer_migrate_folio() except that this variant is more careful
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 767) * and checks that there are also no buffer head references. This function
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 768) * is the right one for mappings where buffer heads are directly looked
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 769) * up and referenced (such as block device mappings).
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 770) *
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 771) * Return: 0 on success or a negative errno on failure.
89cb0888ca1483a Jan Kara 2018-12-28 772 */
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 773) int buffer_migrate_folio_norefs(struct address_space *mapping,
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 774) struct folio *dst, struct folio *src, enum migrate_mode mode)
89cb0888ca1483a Jan Kara 2018-12-28 @775 {
96e64ba8b1be545 Matthew Wilcox (Oracle 2022-06-06 776) return __buffer_migrate_folio(mapping, dst, src, mode, true);
89cb0888ca1483a Jan Kara 2018-12-28 777 }
9361401eb7619c0 David Howells 2006-09-30 778 #endif
1d8b85ccf1ed53a Christoph Lameter 2006-06-23 779

--
0-DAY CI Kernel Test Service