Re: [PATCH 14/20] hugetlb: Convert to migrate_folio

kernel test robot
2022-06-07T06:14:37Z

Hi "Matthew,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.19-rc1 next-20220607]
[cannot apply to jaegeuk-f2fs/dev-test trondmy-nfs/linux-next kdave/for-next xfs-linux/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/Convert-aops-migratepage-to-aops-migrate_folio/20220607-044509
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f2906aa863381afb0015a9eb7fefad885d4e5a56
config: ia64-randconfig-r015-20220605 (https://download.01.org/0day-ci/archive/20220607/202206071414.41wGG8fp-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/b038962c9c8c2ab77c71dfba24356ce24bd7a242
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Convert-aops-migratepage-to-aops-migrate_folio/20220607-044509
git checkout b038962c9c8c2ab77c71dfba24356ce24bd7a242
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash fs/hugetlbfs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

fs/hugetlbfs/inode.c: In function 'hugetlbfs_migrate_folio':
>> fs/hugetlbfs/inode.c:990:17: error: implicit declaration of function 'folio_migrate_copy' [-Werror=implicit-function-declaration]
990 | folio_migrate_copy(dst, src);
| ^~~~~~~~~~~~~~~~~~
>> fs/hugetlbfs/inode.c:992:17: error: implicit declaration of function 'folio_migrate_flags'; did you mean 'folio_mapping_flags'? [-Werror=implicit-function-declaration]
992 | folio_migrate_flags(dst, src);
| ^~~~~~~~~~~~~~~~~~~
| folio_mapping_flags
cc1: some warnings being treated as errors

vim +/folio_migrate_copy +990 fs/hugetlbfs/inode.c

972
973 static int hugetlbfs_migrate_folio(struct address_space *mapping,
974 struct folio *dst, struct folio *src,
975 enum migrate_mode mode)
976 {
977 int rc;
978
979 rc = migrate_huge_page_move_mapping(mapping, dst, src);
980 if (rc != MIGRATEPAGE_SUCCESS)
981 return rc;
982
983 if (hugetlb_page_subpool(&src->page)) {
984 hugetlb_set_page_subpool(&dst->page,
985 hugetlb_page_subpool(&src->page));
986 hugetlb_set_page_subpool(&src->page, NULL);
987 }
988
989 if (mode != MIGRATE_SYNC_NO_COPY)
> 990 folio_migrate_copy(dst, src);
991 else
> 992 folio_migrate_flags(dst, src);
993
994 return MIGRATEPAGE_SUCCESS;
995 }
996

--
0-DAY CI Kernel Test Service