Re: [PATCH] mtd: spi-nor: gigadevice: Add support for gd25lr256e

[Mika Westerberg <mika.westerberg@linux.intel.com>]

Hi,

On Fri, Sep 23, 2022 at 12:33:58PM +0300, Mika Westerberg wrote:
> On Thu, Sep 22, 2022 at 05:38:17PM +0200, Michael Walle wrote:
> > Hi,
> > 
> > Am 2022-09-22 17:11, schrieb Mika Westerberg:
> > > On Thu, Sep 22, 2022 at 05:30:45PM +0300, Mika Westerberg wrote:
> > > > On Thu, Sep 22, 2022 at 04:15:37PM +0200, Michael Walle wrote:
> > > > > Am 2022-09-22 15:56, schrieb Mika Westerberg:
> > > > > > Add support for this 32MB serial flash.
> > > > > >
> > > > > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > > > > ---
> > > > > >  drivers/mtd/spi-nor/gigadevice.c | 4 ++++
> > > > > >  1 file changed, 4 insertions(+)
> > > > > >
> > > > > > diff --git a/drivers/mtd/spi-nor/gigadevice.c
> > > > > > b/drivers/mtd/spi-nor/gigadevice.c
> > > > > > index 119b38e6fc2a..7a7f5cb67a9e 100644
> > > > > > --- a/drivers/mtd/spi-nor/gigadevice.c
> > > > > > +++ b/drivers/mtd/spi-nor/gigadevice.c
> > > > > > @@ -57,6 +57,10 @@ static const struct flash_info gigadevice_nor_parts[]
> > > > > > = {
> > > > > >  		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6)
> > > > > >  		FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
> > > > > >  		.fixups = &gd25q256_fixups },
> > > > > > +	{ "gd25lr256e", INFO(0xc86719, 0, 64 * 1024, 512)
> > > > >
> > > > > There doesn't seem to be a public datasheet. Does this flash support SFDP?
> > > > >
> > > > > In that case, please just use
> > > > > 	{ "gd25lr256e", INFO(0xc86719, 0, 0, 0),
> > > > > 		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> > > > > 		PARSE_SFDP
> > > > > 	}
> > > > >
> > > > 
> > > > Sure, let me check this one works and update the patch accordinglly.
> > > 
> > > Tried this now (I did not find the datasheet either anymore) but I get:
> > > 
> > >   spi-nor spi0.0: BFPT parsing failed. Please consider using
> > > SPI_NOR_SKIP_SFDP when declaring the flash
> > > 
> > > So I suspect SFDP is not supported by this chip?
> > 
> > According to https://www.gigadevice.com/flash-memory/gd25lr256e/
> > it has SFDP. Could you debug what is going wrong here?
> 
> Sure, I'll see if I can figure out why it fails.

Okay debugged now. It turns out that yes this chip supports SFDP just
fine. It is the Intel SPI driver that did not so that's the reason for
the failure here.

I will submit v2 of this patch after v6.1-rc1 is released and also send
out the patch series adding SFDP support to the Intel SPI driver.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/