From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Zhihao Cheng <chengzhihao1@huawei.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v2 1/1] mtd: mtdpart: Do not supply NULL to printf()
Date: Thu, 13 Mar 2025 15:56:56 +0200 [thread overview]
Message-ID: <Z9LkKLLl2Z5cANga@smile.fi.intel.com> (raw)
In-Reply-To: <f17a1851-7360-3f18-4e89-dbf6948eeaff@huawei.com>
On Thu, Mar 13, 2025 at 09:09:09PM +0800, Zhihao Cheng wrote:
> 在 2025/3/13 17:15, Andy Shevchenko 写道:
> > GCC compiler is not happy about NULL being supplied as printf() parameter:
> >
> > drivers/mtd/mtdpart.c:693:34: error: ‘%s’ directive argument is null [-Werror=format-overflow=]
> >
> > Move the code after the parser test for NULL, and drop the ternary completely.
> > The user can deduct this since when it's not NULL two messages will be printed.
> Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Thank you!
--
With Best Regards,
Andy Shevchenko
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-03-13 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 9:15 [PATCH v2 1/1] mtd: mtdpart: Do not supply NULL to printf() Andy Shevchenko
2025-03-13 13:09 ` Zhihao Cheng
2025-03-13 13:56 ` Andy Shevchenko [this message]
2025-03-18 16:18 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9LkKLLl2Z5cANga@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=chengzhihao1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox