Re: [PATCH 47/49] mtd: rawnand: tegra: Convert to platform remove callback returning void

From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Stefan Agner <stefan@agner.ch>, Lucas Stach <dev@lynxeye.de>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org, linux-tegra@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH 47/49] mtd: rawnand: tegra: Convert to platform remove callback returning void
Date: Wed, 5 Apr 2023 13:13:24 +0200	[thread overview]
Message-ID: <ZC1X1IdDiaPvBXdg@orome> (raw)
In-Reply-To: <20230401161938.2503204-48-u.kleine-koenig@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 880 bytes --]

On Sat, Apr 01, 2023 at 06:19:36PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/mtd/nand/raw/tegra_nand.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/